From: Breno Lima <brenomatheus@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] imx: hab: Ensure the IVT DCD pointer is Null prior to calling HAB authenticate function.
Date: Tue, 20 Feb 2018 01:19:23 +0000 [thread overview]
Message-ID: <1519089566-17147-2-git-send-email-brenomatheus@gmail.com> (raw)
In-Reply-To: <1519089566-17147-1-git-send-email-brenomatheus@gmail.com>
From: Utkarsh Gupta <utkarsh.gupta@nxp.com>
DCD commands should only be present in the initial boot image loaded by
the SoC ROM. DCD should not be present in images that will be verified
by software using HAB RVT authentication APIs. Newer versions of HAB
will generate an error if a DCD pointer is present in an image being
authenticated by calling the HAB RVT API. Older versions of HAB will
process and run DCD if it is present, and this could lead to an incorrect
authentication boot flow.
It is highly recommended this check is in place to ensure additional HAB
verified images do not include a DCD table.
Signed-off-by: Utkarsh Gupta <utkarsh.gupta@nxp.com>
Signed-off-by: Breno Lima <breno.lima@nxp.com>
---
arch/arm/mach-imx/hab.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/mach-imx/hab.c b/arch/arm/mach-imx/hab.c
index 1e6b31d..ba6b31d 100644
--- a/arch/arm/mach-imx/hab.c
+++ b/arch/arm/mach-imx/hab.c
@@ -516,6 +516,12 @@ int imx_hab_authenticate_image(uint32_t ddr_start, uint32_t image_size,
goto hab_authentication_exit;
}
+ /* Verify if IVT DCD pointer is NULL */
+ if (ivt->dcd) {
+ puts("Error: DCD pointer must be NULL\n");
+ goto hab_authentication_exit;
+ }
+
start = ddr_start;
bytes = image_size;
--
2.7.4
next prev parent reply other threads:[~2018-02-20 1:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 1:19 [U-Boot] [PATCH 1/5] imx: hab: Keep CAAM clock enabled after authenticating additional images Breno Lima
2018-02-20 1:19 ` Breno Lima [this message]
2018-02-20 10:44 ` [U-Boot] [PATCH 2/5] imx: hab: Ensure the IVT DCD pointer is Null prior to calling HAB authenticate function Fabio Estevam
2018-02-20 1:19 ` [U-Boot] [PATCH 3/5] imx: hab: Check if CSF is valid before authenticating image Breno Lima
2018-02-20 10:45 ` Fabio Estevam
2018-02-20 1:19 ` [U-Boot] [PATCH 4/5] imx: hab: Check if CSF contains deprecated commands Breno Lima
2018-02-20 10:45 ` Fabio Estevam
2018-02-20 1:19 ` [U-Boot] [PATCH 5/5] arm: imx: hab: Define HAB_RVT_BASE according to the processor version Breno Lima
2018-02-20 10:45 ` Fabio Estevam
2018-02-20 10:44 ` [U-Boot] [PATCH 1/5] imx: hab: Keep CAAM clock enabled after authenticating additional images Fabio Estevam
2018-02-22 13:36 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519089566-17147-2-git-send-email-brenomatheus@gmail.com \
--to=brenomatheus@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox