From: Chee, Tien Fong <tien.fong.chee@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v8 3/4] cmd: ubifs: Factor out some checking codes into cmd_ubifs_mount()
Date: Thu, 22 Feb 2018 06:04:18 +0000 [thread overview]
Message-ID: <1519279457.9210.0.camel@intel.com> (raw)
In-Reply-To: <fc306305-7b54-6591-73c0-a2bd739d32a6@denx.de>
On Thu, 2018-02-15 at 15:59 +0100, Marek Vasut wrote:
> On 02/05/2018 08:06 AM, tien.fong.chee at intel.com wrote:
> >
> > From: Tien Fong Chee <tien.fong.chee@intel.com>
> >
> > cmd_ubifs_mount() function would be called directly instead of
> > involving whole command machinery for mounting ubifs in
> > generic firmware loader, so some checking codes need to be factored
> > out
> > into cmd_ubifs_mount() without breaking original functionality
> > design.
> >
> > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> [...]
>
> >
> > diff --git a/include/ubi_uboot.h b/include/ubi_uboot.h
> > index 827dbfc..fb300e8 100644
> > --- a/include/ubi_uboot.h
> > +++ b/include/ubi_uboot.h
> > @@ -76,5 +76,6 @@ extern int ubi_volume_read(char *volume, char
> > *buf, size_t size);
> >
> > extern struct ubi_device *ubi_devices[];
> > int cmd_ubifs_umount(void);
> > +int cmd_ubifs_mount(char *vol_name);
> Swap these two -- mount first and umount seconds.
>
Okay. noted.
> With that
> Reviewed-by: Marek Vasut <marex@denx.de>
>
next prev parent reply other threads:[~2018-02-22 6:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 7:06 [U-Boot] [PATCH v8 0/4] Generic firmware loader tien.fong.chee at intel.com
2018-02-05 7:06 ` [U-Boot] [PATCH v8 1/4] spl: Remove static declaration on spl_mmc_find_device function tien.fong.chee at intel.com
2018-02-15 14:58 ` Marek Vasut
2018-02-05 7:06 ` [U-Boot] [PATCH v8 2/4] cmd: ubifs: Move ubifs_initialized checking into cmd_ubifs_umount() tien.fong.chee at intel.com
2018-02-15 14:58 ` Marek Vasut
2018-02-05 7:06 ` [U-Boot] [PATCH v8 3/4] cmd: ubifs: Factor out some checking codes into cmd_ubifs_mount() tien.fong.chee at intel.com
2018-02-15 14:59 ` Marek Vasut
2018-02-22 6:04 ` Chee, Tien Fong [this message]
2018-02-05 7:06 ` [U-Boot] [PATCH v8 4/4] common: Generic firmware loader for file system tien.fong.chee at intel.com
2018-02-15 14:58 ` Marek Vasut
2018-02-22 8:18 ` Chee, Tien Fong
2018-02-22 14:28 ` Marek Vasut
2018-02-22 15:50 ` Tom Rini
2018-02-26 6:22 ` Chee, Tien Fong
2018-02-26 6:20 ` Chee, Tien Fong
2018-02-22 9:02 ` Lothar Waßmann
2018-02-26 6:24 ` Chee, Tien Fong
2018-02-15 10:22 ` [U-Boot] [PATCH v8 0/4] Generic firmware loader Chee, Tien Fong
2018-02-15 10:28 ` Chee, Tien Fong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519279457.9210.0.camel@intel.com \
--to=tien.fong.chee@intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox