From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chee, Tien Fong Date: Thu, 22 Feb 2018 06:04:18 +0000 Subject: [U-Boot] [PATCH v8 3/4] cmd: ubifs: Factor out some checking codes into cmd_ubifs_mount() In-Reply-To: References: <1517814409-25698-1-git-send-email-tien.fong.chee@intel.com> <1517814409-25698-4-git-send-email-tien.fong.chee@intel.com> Message-ID: <1519279457.9210.0.camel@intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On Thu, 2018-02-15 at 15:59 +0100, Marek Vasut wrote: > On 02/05/2018 08:06 AM, tien.fong.chee at intel.com wrote: > > > > From: Tien Fong Chee > > > > cmd_ubifs_mount() function would be called directly instead of > > involving whole command machinery for mounting ubifs in > > generic firmware loader, so some checking codes need to be factored > > out > > into cmd_ubifs_mount() without breaking original functionality > > design. > > > > Signed-off-by: Tien Fong Chee > [...] > > > > > diff --git a/include/ubi_uboot.h b/include/ubi_uboot.h > > index 827dbfc..fb300e8 100644 > > --- a/include/ubi_uboot.h > > +++ b/include/ubi_uboot.h > > @@ -76,5 +76,6 @@ extern int ubi_volume_read(char *volume, char > > *buf, size_t size); > >   > >  extern struct ubi_device *ubi_devices[]; > >  int cmd_ubifs_umount(void); > > +int cmd_ubifs_mount(char *vol_name); > Swap these two -- mount first and umount seconds. > Okay. noted. > With that > Reviewed-by: Marek Vasut >