public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: See, Chin Liang <chin.liang.see@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] arm: socfpga: cyclone5: Ensure spi-flash in the compatible string
Date: Wed, 21 Feb 2018 14:01:24 +0000	[thread overview]
Message-ID: <1519308132.2582.1.camel@intel.com> (raw)
In-Reply-To: <af10753c-1a84-e5ae-c38b-c7db10524c61@de.pepperl-fuchs.com>

On Wed, 2018-02-21 at 10:34 +0100, Simon Goldschmidt wrote:
> On 21.02.2018 08:40, chin.liang.see at intel.com wrote:
> > 
> > From: Chin Liang See <chin.liang.see@intel.com>
> > 
> > Ensure "spi-flash" is added into compatible string when there is
> > NOR flash being instantiated in DTS. Discovered "sf probe" command
> > without argument would hit error if spi-flash compatible string
> > is missing.
> This has already been fixed 5 days ago.
> 

Nice and thanks for the patch.
I was pulling from the source few days back for enabling the Macronix
flash and bumping into this same issue.

Thanks
Chin Liang

> Simon
> 
> > 
> > 
> > Signed-off-by: Chin Liang See <chin.liang.see@intel.com>
> > ---
> >   arch/arm/dts/socfpga_cyclone5_is1.dts      | 2 +-
> >   arch/arm/dts/socfpga_cyclone5_socdk.dts    | 2 +-
> >   arch/arm/dts/socfpga_cyclone5_socrates.dts | 2 +-
> >   3 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/arch/arm/dts/socfpga_cyclone5_is1.dts
> > b/arch/arm/dts/socfpga_cyclone5_is1.dts
> > index 2e2b71f..549024c 100644
> > --- a/arch/arm/dts/socfpga_cyclone5_is1.dts
> > +++ b/arch/arm/dts/socfpga_cyclone5_is1.dts
> > @@ -87,7 +87,7 @@
> >   		u-boot,dm-pre-reloc;
> >   		#address-cells = <1>;
> >   		#size-cells = <1>;
> > -		compatible = "n25q00";
> > +		compatible = "n25q00","spi-flash";
> >   		reg = <0>;      /* chip select */
> >   		spi-max-frequency = <100000000>;
> >   		m25p,fast-read;
> > diff --git a/arch/arm/dts/socfpga_cyclone5_socdk.dts
> > b/arch/arm/dts/socfpga_cyclone5_socdk.dts
> > index 95a8e65..e30bf9a 100644
> > --- a/arch/arm/dts/socfpga_cyclone5_socdk.dts
> > +++ b/arch/arm/dts/socfpga_cyclone5_socdk.dts
> > @@ -98,7 +98,7 @@
> >   		u-boot,dm-pre-reloc;
> >   		#address-cells = <1>;
> >   		#size-cells = <1>;
> > -		compatible = "n25q00";
> > +		compatible = "n25q00","spi-flash";
> >   		reg = <0>;      /* chip select */
> >   		spi-max-frequency = <100000000>;
> >   		m25p,fast-read;
> > diff --git a/arch/arm/dts/socfpga_cyclone5_socrates.dts
> > b/arch/arm/dts/socfpga_cyclone5_socrates.dts
> > index e3ae8a8..3e78038 100644
> > --- a/arch/arm/dts/socfpga_cyclone5_socrates.dts
> > +++ b/arch/arm/dts/socfpga_cyclone5_socrates.dts
> > @@ -68,7 +68,7 @@
> >   	flash0: n25q00 at 0 {
> >   		#address-cells = <1>;
> >   		#size-cells = <1>;
> > -		compatible = "n25q00";
> > +		compatible = "n25q00","spi-flash";
> >   		reg = <0>;      /* chip select */
> >   		spi-max-frequency = <50000000>;
> >   		m25p,fast-read;

      reply	other threads:[~2018-02-21 14:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-21  7:40 [U-Boot] [PATCH 2/2] arm: socfpga: cyclone5: Ensure spi-flash in the compatible string chin.liang.see at intel.com
2018-02-21  9:34 ` Simon Goldschmidt
2018-02-21 14:01   ` See, Chin Liang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1519308132.2582.1.camel@intel.com \
    --to=chin.liang.see@intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox