From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chee, Tien Fong <tien.fong.chee@intel.com>
Date: Mon, 26 Feb 2018 06:24:09 +0000
Subject: [U-Boot] [PATCH v8 4/4] common: Generic firmware loader for
	file system
In-Reply-To: <20180222100233.3d67485d@karo-electronics.de>
References: <1517814409-25698-1-git-send-email-tien.fong.chee@intel.com>
 <1517814409-25698-5-git-send-email-tien.fong.chee@intel.com>
 <20180222100233.3d67485d@karo-electronics.de>
Message-ID: <1519626249.12632.8.camel@intel.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
To: u-boot@lists.denx.de

On Thu, 2018-02-22 at 10:02 +0100, Lothar Waßmann wrote:
> Hi,
> 
> On Mon,  5 Feb 2018 15:06:49 +0800 tien.fong.chee at intel.com wrote:
> > 
> > From: Tien Fong Chee <tien.fong.chee@intel.com>
> > 
> > This is file system generic loader which can be used to load
> > the file image from the storage into target such as memory.
> > The consumer driver would then use this loader to program whatever,
> > ie. the FPGA device.
> > 
> > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > Reviewed-by: Lothar Waßmann <LW@KARO-electronics.de>
> > ---
> >  common/Kconfig             |   9 ++
> >  common/Makefile            |   1 +
> >  common/fs_loader.c         | 320
> > +++++++++++++++++++++++++++++++++++++++++++++
> >  doc/README.firmware_loader |  76 +++++++++++
> >  include/fs_loader.h        |  28 ++++
> >  5 files changed, 434 insertions(+)
> >  create mode 100644 common/fs_loader.c
> >  create mode 100644 doc/README.firmware_loader
> >  create mode 100644 include/fs_loader.h
> > 
> [...]
> > 
> > +#if defined(CONFIG_SPL_MMC_SUPPORT) && defined(CONFIG_SPL_BUILD)
> > +__weak int init_mmc(void)
> > +{
> > +	/* Just for the case MMC is not yet initialized */
> > +	struct mmc *mmc = NULL;
> > +	int err;
> > +
> > +#ifdef CONFIG_SPL
> > +	spl_mmc_find_device(&mmc, spl_boot_device());
> > +#else
> > +	debug("#define CONFIG_SPL is required or overrriding
> > %s\n",
> > 
> s/overrr/overr/
> 
I would remove it and adding the depend on CONFIG_SPL in Kconfig for
compile-time error checking.
> 
> 
> Lothar Waßmann