[U-Boot] [PATCH 1/3] arm: dts: sun7i: Update Ainol AW1 dts

Maxime Ripard
2018-03-26T13:13:04Z

On Mon, Mar 26, 2018 at 02:39:23PM +0200, Paul Kocialkowski wrote:
> > Your nodes should be ordered by alphabetical order (at least as much
> > as possible, this isn't really doable for all the AXP stuff).
>
> I tried to preserve the order from the sun7i-a20.dtsi file, which felt
> like the most straightforward thing to do.
>
> Is there any particlar reason why things should be sorted
> alphabetically? It feels like it has the potential to explode related
> blocs in different areas of the file, thus reducing readability (like
> you've mentioned for the AXP).

It's what we're doing everywhere else would be a great reason :)

The second, and the reason we actually did this in the first place, is
that it's self sufficient, you don't need to rely on any other DTSI
file to know which order you're suppose to have.

That becomes especially tricky when you're merging various DTSI
together (which order should comes first?), or when you don't always
access a node to the same depth (ie tcon vs tcon_out).

While alphabetical order is easy to understand, follow and to check
during the reviews.

Maxime

--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180326/edb88ef1/attachment.sig>