From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Date: Wed, 4 Apr 2018 08:51:16 +0000 Subject: [U-Boot] [PATCH] Makefile: Disable stack-usage check for ARC In-Reply-To: <20180403204920.GN19725@bill-the-cat.ec.rr.com> References: <20180402091802.23753-1-abrodkin@synopsys.com> <20180403201742.GL19725@bill-the-cat.ec.rr.com> <1522786865.14857.2.camel@synopsys.com> <20180403202500.GM19725@bill-the-cat.ec.rr.com> <1522787239.14857.5.camel@synopsys.com> <20180403204920.GN19725@bill-the-cat.ec.rr.com> Message-ID: <1522831875.4851.5.camel@synopsys.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, On Tue, 2018-04-03 at 16:49 -0400, Tom Rini wrote: > On Tue, Apr 03, 2018 at 08:27:20PM +0000, Alexey Brodkin wrote: > > Hi Tom, > > > > On Tue, 2018-04-03 at 16:25 -0400, Tom Rini wrote: > > > On Tue, Apr 03, 2018 at 08:21:06PM +0000, Alexey Brodkin wrote: > > > > Hi Tom, > > > > > > > > On Tue, 2018-04-03 at 16:17 -0400, Tom Rini wrote: > > > > > On Mon, Apr 02, 2018 at 12:18:02PM +0300, Alexey Brodkin wrote: > > > > > > > > > > > With the most recent tools for ARC (arc-2017.09) in case of > > > > > > "naked" function compiler throws a warning: > > > > > > ---------------------------------->8----------------------------- > > > > > > board/synopsys/hsdk/hsdk.c: In function 'hsdk_core_init_f': > > > > > > board/synopsys/hsdk/hsdk.c:345:1: warning: stack usage computation not supported for this target > > > > > > } > > > > > > ^ > > > > > > ---------------------------------->8----------------------------- > > > > > > > > > > > > That happens because the compiler doesn't handle "naked" functions > > > > > > as a special case where stack calculation shouldn't be done. > > > > > > > > > > > > But for now until this is fixed in GCC to get clean buildman output > > > > > > we're disabling stack-usage check for ARC. > > > > > > > > > > > > See https://lists.denx.de/pipermail/u-boot/2018-April/324455.html > > > > > > for more background. > > > > > > > > > > > > Signed-off-by: Alexey Brodkin > > > > > > Cc: Masahiro Yamada > > > > > > Cc: Tom Rini > > > > > > > > > > Erm, this patch isn't working for me. I take the current ARC PR, and > > > > > apply this, and I still see the warning showing up. > > > > > > > > How do you see an issue? > > > > Could you please make sure arc-2017.09 tools are used but not arc-2016.09? > > > > See my change for TravisCI in the same PR. > > > > > > ... but the patch here is disabling -fstack-usage altogether for ARC, > > > yes? > > > > Right, but that's a temporary "patch" for the problem in hand. > > Once GCC 8.x gets released we'll just switch to it and that problem shouldn't > > bother us any longer. > > OK. But this patch doesn't work and we're trying -fstack-usage is the > problem I see :) Well probably I'm missing something :) Here's a TravisCI job for ARC that passes perfectly fine: https://travis-ci.org/abrodkin/u-boot/jobs/362026822 Stuff that is built there is here: https://github.com/abrodkin/u-boot/commits/staging-arc Basically it's: * v2018.05-rc1 + * My last PR (tags/arc-for-2018.05) + * [This] "disable stack-usage" patch ------------------------>8------------------------ # git log --oneline 7917ac883723 Makefile: Disable stack-usage check for ARC 9fe2b77b313b ARC: HSDK: Enable SPI flash support 11007a25b835 ARC: HSDK: Add platform-specific commands 416c03d2f09f ARC: Bump ARC tools used in TravisCI to the most recent release arc-2017.09 94f247d0c145 ARC: AXS10x: DTS: Remove unused interrupt properties 645b5afbb821 (tag: v2018.05-rc1, mainline/master) Prepare v2018.05-rc1 ------------------------>8------------------------ -Alexey