public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] SPI Flash: add support of sst26wf* flash series
Date: Thu, 5 Apr 2018 12:40:19 +0000	[thread overview]
Message-ID: <1522932018.2830.8.camel@synopsys.com> (raw)
In-Reply-To: <CAD6G_RR3Yr_GPn8C23-dB4ocVDpZ19UNhXNW+8D6daVMN2ROZw@mail.gmail.com>

On Wed, 2018-04-04 at 19:58 +0530, Jagan Teki wrote:
> On Mon, Mar 26, 2018 at 4:38 PM, Eugeniy Paltsev
> <Eugeniy.Paltsev@synopsys.com> wrote:
> > sst26wf flash series block protection implementation differs
> > from other SST series, so add implementation for sst26wf
> > lock/unlock/is_locked functions.
[snip]
> > 
> > +/* sst26wf series block protection implementation differs from other series */
> > +#if defined(CONFIG_SPI_FLASH_SST)
> > +       if (JEDEC_MFR(info) == SPI_FLASH_CFI_MFR_SST &&
> > +           (JEDEC_ID(info) >> 8) == 0x26) {
> 
> You can directly use JEDEC_ID that may cover id[0], id[1]? or does
> this only for id[0]?

It is only for "JEDEC Device Type Byte" (byte 1) == 0x26;
"Device ID Byte" (byte 2) can be any.

But I can write it like
  (info->id[1] == 0x26)
instead of
  ((JEDEC_ID(info) >> 8) == 0x26)

-- 
 Eugeniy Paltsev

  reply	other threads:[~2018-04-05 12:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-26 11:08 [U-Boot] [PATCH v2 0/2] SF: add support for sst26wf016, sst26wf032, sst26wf064 Eugeniy Paltsev
2018-03-26 11:08 ` [U-Boot] [PATCH v2 1/2] SPI Flash: add support of sst26wf* flash series Eugeniy Paltsev
2018-04-04 13:43   ` Jagan Teki
2018-04-04 13:50     ` Alexey Brodkin
2018-04-04 14:07       ` Jagan Teki
2018-04-04 14:28   ` Jagan Teki
2018-04-05 12:40     ` Eugeniy Paltsev [this message]
2018-04-05 12:49       ` Jagan Teki
2018-03-26 11:08 ` [U-Boot] [PATCH v2 2/2] SF: add support for sst26wf016, sst26wf032, sst26wf064 Eugeniy Paltsev
2018-03-26 15:26 ` [U-Boot] [uboot-snps-arc] [PATCH v2 0/2] " Alexey Brodkin
2018-03-30 12:04 ` Alexey Brodkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1522932018.2830.8.camel@synopsys.com \
    --to=eugeniy.paltsev@synopsys.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox