From: Dinh Nguyen <dinguyen@kernel.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv1 10/14] net: dwc_eth_qos: remove reset_free from driver
Date: Sat, 14 Apr 2018 13:51:36 -0500 [thread overview]
Message-ID: <1523731900-4675-11-git-send-email-dinguyen@kernel.org> (raw)
In-Reply-To: <1523731900-4675-1-git-send-email-dinguyen@kernel.org>
The call to free the reset control line is a deadend call that doesn't
lead to any reset control functionality.
Also the reset_free() function will be remove in a subsequent patch, so
remove it here.
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
---
drivers/net/dwc_eth_qos.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
index 232e803..a3f1b40 100644
--- a/drivers/net/dwc_eth_qos.c
+++ b/drivers/net/dwc_eth_qos.c
@@ -1371,7 +1371,6 @@ static int eqos_probe_resources_tegra186(struct udevice *dev)
GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE);
if (ret) {
pr_err("gpio_request_by_name(phy reset) failed: %d", ret);
- goto err_free_reset_eqos;
}
ret = clk_get_by_name(dev, "slave_bus", &eqos->clk_slave_bus);
@@ -1418,8 +1417,6 @@ err_free_clk_slave_bus:
clk_free(&eqos->clk_slave_bus);
err_free_gpio_phy_reset:
dm_gpio_free(dev, &eqos->phy_reset_gpio);
-err_free_reset_eqos:
- reset_free(&eqos->reset_ctl);
debug("%s: returns %d\n", __func__, ret);
return ret;
@@ -1437,7 +1434,6 @@ static int eqos_remove_resources_tegra186(struct udevice *dev)
clk_free(&eqos->clk_slave_bus);
clk_free(&eqos->clk_master_bus);
dm_gpio_free(dev, &eqos->phy_reset_gpio);
- reset_free(&eqos->reset_ctl);
debug("%s: OK\n", __func__);
return 0;
--
2.7.4
next prev parent reply other threads:[~2018-04-14 18:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 18:51 [U-Boot] [PATCHv1 00/14] reset: remove request and free functions Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 01/14] reset: tegra: " Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 02/14] reset: sti: " Dinh Nguyen
2018-04-17 11:57 ` Patrice CHOTARD
2018-04-14 18:51 ` [U-Boot] [PATCHv1 03/14] reset: uniphier: " Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 04/14] reset: rockchip: " Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 05/14] reset: meson: " Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 06/14] reset: bcm6345: " Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 07/14] reset: ast2500: remove request function Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 08/14] reset: socfpga: remove request and free functions Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 09/14] reset: sandbox: " Dinh Nguyen
2018-04-14 18:51 ` Dinh Nguyen [this message]
2018-04-14 18:51 ` [U-Boot] [PATCHv1 11/14] phy: bcm63xx: remove reset_free function Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 12/14] usb: ehci/ohci: " Dinh Nguyen
2018-04-17 11:58 ` Patrice CHOTARD
2018-04-14 18:51 ` [U-Boot] [PATCHv1 13/14] reset: test: remove sandbox_reset_test_free function Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 14/14] reset: remove request and free functions Dinh Nguyen
2018-04-16 18:43 ` Simon Glass
2018-04-16 18:51 ` Stephen Warren
2018-04-16 20:41 ` Dinh Nguyen
2018-04-17 23:21 ` Simon Glass
2018-04-16 20:38 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1523731900-4675-11-git-send-email-dinguyen@kernel.org \
--to=dinguyen@kernel.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox