From: Dinh Nguyen <dinguyen@kernel.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv1 12/14] usb: ehci/ohci: remove reset_free function
Date: Sat, 14 Apr 2018 13:51:38 -0500 [thread overview]
Message-ID: <1523731900-4675-13-git-send-email-dinguyen@kernel.org> (raw)
In-Reply-To: <1523731900-4675-1-git-send-email-dinguyen@kernel.org>
The call to free the reset control line is a deadend call that doesn't
lead to any reset control functionality.
Also the reset_free() function will be remove in a subsequent patch, so
remove it here.
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
---
drivers/usb/host/ehci-generic.c | 1 -
drivers/usb/host/ohci-generic.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/usb/host/ehci-generic.c b/drivers/usb/host/ehci-generic.c
index b012d86..8ed6a27 100644
--- a/drivers/usb/host/ehci-generic.c
+++ b/drivers/usb/host/ehci-generic.c
@@ -133,7 +133,6 @@ static int ehci_usb_probe(struct udevice *dev)
if (reset_deassert(&priv->resets[i])) {
dev_err(dev, "failed to deassert reset %d\n",
i);
- reset_free(&priv->resets[i]);
goto reset_err;
}
priv->reset_count++;
diff --git a/drivers/usb/host/ohci-generic.c b/drivers/usb/host/ohci-generic.c
index 5bdd799..f61c0fc 100644
--- a/drivers/usb/host/ohci-generic.c
+++ b/drivers/usb/host/ohci-generic.c
@@ -125,7 +125,6 @@ static int ohci_usb_probe(struct udevice *dev)
err = reset_deassert(&priv->resets[i]);
if (err) {
dev_err(dev, "failed to deassert reset %d\n", i);
- reset_free(&priv->resets[i]);
goto reset_err;
}
priv->reset_count++;
--
2.7.4
next prev parent reply other threads:[~2018-04-14 18:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 18:51 [U-Boot] [PATCHv1 00/14] reset: remove request and free functions Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 01/14] reset: tegra: " Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 02/14] reset: sti: " Dinh Nguyen
2018-04-17 11:57 ` Patrice CHOTARD
2018-04-14 18:51 ` [U-Boot] [PATCHv1 03/14] reset: uniphier: " Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 04/14] reset: rockchip: " Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 05/14] reset: meson: " Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 06/14] reset: bcm6345: " Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 07/14] reset: ast2500: remove request function Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 08/14] reset: socfpga: remove request and free functions Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 09/14] reset: sandbox: " Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 10/14] net: dwc_eth_qos: remove reset_free from driver Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 11/14] phy: bcm63xx: remove reset_free function Dinh Nguyen
2018-04-14 18:51 ` Dinh Nguyen [this message]
2018-04-17 11:58 ` [U-Boot] [PATCHv1 12/14] usb: ehci/ohci: " Patrice CHOTARD
2018-04-14 18:51 ` [U-Boot] [PATCHv1 13/14] reset: test: remove sandbox_reset_test_free function Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 14/14] reset: remove request and free functions Dinh Nguyen
2018-04-16 18:43 ` Simon Glass
2018-04-16 18:51 ` Stephen Warren
2018-04-16 20:41 ` Dinh Nguyen
2018-04-17 23:21 ` Simon Glass
2018-04-16 20:38 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1523731900-4675-13-git-send-email-dinguyen@kernel.org \
--to=dinguyen@kernel.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox