[U-Boot] [PATCHv1 02/14] reset: sti: remove request and free functions

Patrice CHOTARD
2018-04-17T11:57:53Z

Hi Dinh

On 04/14/2018 08:51 PM, Dinh Nguyen wrote:
> The request and free reset functions are not really used for any useful
> purpose but for debugging. We can safely remove them.
>
> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
> ---
> drivers/reset/sti-reset.c | 12 ------------
> drivers/reset/stm32-reset.c | 12 ------------
> 2 files changed, 24 deletions(-)
>
> diff --git a/drivers/reset/sti-reset.c b/drivers/reset/sti-reset.c
> index 0fc5a28..672dd97 100644
> --- a/drivers/reset/sti-reset.c
> +++ b/drivers/reset/sti-reset.c
> @@ -277,16 +277,6 @@ static int sti_reset_program_hw(struct reset_ctl *reset_ctl, int assert)
> return 0;
> }
>
> -static int sti_reset_request(struct reset_ctl *reset_ctl)
> -{
> - return 0;
> -}
> -
> -static int sti_reset_free(struct reset_ctl *reset_ctl)
> -{
> - return 0;
> -}
> -
> static int sti_reset_assert(struct reset_ctl *reset_ctl)
> {
> return sti_reset_program_hw(reset_ctl, true);
> @@ -298,8 +288,6 @@ static int sti_reset_deassert(struct reset_ctl *reset_ctl)
> }
>
> struct reset_ops sti_reset_ops = {
> - .request = sti_reset_request,
> - .free = sti_reset_free,
> .rst_assert = sti_reset_assert,
> .rst_deassert = sti_reset_deassert,
> };
> diff --git a/drivers/reset/stm32-reset.c b/drivers/reset/stm32-reset.c
> index e98f34b..efde745 100644
> --- a/drivers/reset/stm32-reset.c
> +++ b/drivers/reset/stm32-reset.c
> @@ -23,16 +23,6 @@ struct stm32_reset_priv {
> fdt_addr_t base;
> };
>
> -static int stm32_reset_request(struct reset_ctl *reset_ctl)
> -{
> - return 0;
> -}
> -
> -static int stm32_reset_free(struct reset_ctl *reset_ctl)
> -{
> - return 0;
> -}
> -
> static int stm32_reset_assert(struct reset_ctl *reset_ctl)
> {
> struct stm32_reset_priv *priv = dev_get_priv(reset_ctl->dev);
> @@ -68,8 +58,6 @@ static int stm32_reset_deassert(struct reset_ctl *reset_ctl)
> }
>
> static const struct reset_ops stm32_reset_ops = {
> - .request = stm32_reset_request,
> - .free = stm32_reset_free,
> .rst_assert = stm32_reset_assert,
> .rst_deassert = stm32_reset_deassert,
> };
>

Reviewed-by: Patrice Chotard <patrice.chotard@st.com>

Thanks