From: Dinh Nguyen <dinguyen@kernel.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv1 06/14] reset: bcm6345: remove request and free functions
Date: Sat, 14 Apr 2018 13:51:32 -0500 [thread overview]
Message-ID: <1523731900-4675-7-git-send-email-dinguyen@kernel.org> (raw)
In-Reply-To: <1523731900-4675-1-git-send-email-dinguyen@kernel.org>
The request and free reset functions are not really used for any useful
purpose but for debugging. We can safely remove them.
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
---
drivers/reset/reset-bcm6345.c | 21 ++++++---------------
1 file changed, 6 insertions(+), 15 deletions(-)
diff --git a/drivers/reset/reset-bcm6345.c b/drivers/reset/reset-bcm6345.c
index ebf6bee..b49a2f1 100644
--- a/drivers/reset/reset-bcm6345.c
+++ b/drivers/reset/reset-bcm6345.c
@@ -23,6 +23,9 @@ static int bcm6345_reset_assert(struct reset_ctl *rst)
{
struct bcm6345_reset_priv *priv = dev_get_priv(rst->dev);
+ if (rst->id >= MAX_RESETS)
+ return -EINVAL;
+
clrbits_be32(priv->regs, BIT(rst->id));
mdelay(20);
@@ -33,28 +36,16 @@ static int bcm6345_reset_deassert(struct reset_ctl *rst)
{
struct bcm6345_reset_priv *priv = dev_get_priv(rst->dev);
+ if (rst->id >= MAX_RESETS)
+ return -EINVAL;
+
setbits_be32(priv->regs, BIT(rst->id));
mdelay(20);
return 0;
}
-static int bcm6345_reset_free(struct reset_ctl *rst)
-{
- return 0;
-}
-
-static int bcm6345_reset_request(struct reset_ctl *rst)
-{
- if (rst->id >= MAX_RESETS)
- return -EINVAL;
-
- return bcm6345_reset_assert(rst);
-}
-
struct reset_ops bcm6345_reset_reset_ops = {
- .free = bcm6345_reset_free,
- .request = bcm6345_reset_request,
.rst_assert = bcm6345_reset_assert,
.rst_deassert = bcm6345_reset_deassert,
};
--
2.7.4
next prev parent reply other threads:[~2018-04-14 18:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 18:51 [U-Boot] [PATCHv1 00/14] reset: remove request and free functions Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 01/14] reset: tegra: " Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 02/14] reset: sti: " Dinh Nguyen
2018-04-17 11:57 ` Patrice CHOTARD
2018-04-14 18:51 ` [U-Boot] [PATCHv1 03/14] reset: uniphier: " Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 04/14] reset: rockchip: " Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 05/14] reset: meson: " Dinh Nguyen
2018-04-14 18:51 ` Dinh Nguyen [this message]
2018-04-14 18:51 ` [U-Boot] [PATCHv1 07/14] reset: ast2500: remove request function Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 08/14] reset: socfpga: remove request and free functions Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 09/14] reset: sandbox: " Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 10/14] net: dwc_eth_qos: remove reset_free from driver Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 11/14] phy: bcm63xx: remove reset_free function Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 12/14] usb: ehci/ohci: " Dinh Nguyen
2018-04-17 11:58 ` Patrice CHOTARD
2018-04-14 18:51 ` [U-Boot] [PATCHv1 13/14] reset: test: remove sandbox_reset_test_free function Dinh Nguyen
2018-04-14 18:51 ` [U-Boot] [PATCHv1 14/14] reset: remove request and free functions Dinh Nguyen
2018-04-16 18:43 ` Simon Glass
2018-04-16 18:51 ` Stephen Warren
2018-04-16 20:41 ` Dinh Nguyen
2018-04-17 23:21 ` Simon Glass
2018-04-16 20:38 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1523731900-4675-7-git-send-email-dinguyen@kernel.org \
--to=dinguyen@kernel.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox