public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: See, Chin Liang <chin.liang.see@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5] ARM: socfpga: Add boot trampoline for Arria10
Date: Tue, 17 Apr 2018 08:40:14 +0000	[thread overview]
Message-ID: <1523954412.2582.13.camel@intel.com> (raw)
In-Reply-To: <20180415133704.18950-1-marex@denx.de>

Hi Marek,

On Sun, 2018-04-15 at 15:37 +0200, Marek Vasut wrote:
> The Arria10 uses slightly different boot image header than the Gen5
> SoCs,
> in particular the header itself contains an offset from the start of
> the
> header to which the Arria10 jumps. This offset must not be negative,
> yet
> the header is placed at offset 0x40 of the bootable binary.
> Therefore, to
> jump into U-Boot, add a trampoline just past the Arria10 boot header
> and
> point to this trampoline at fixed offset from the header generated
> using
> the mkimage -T socfpgaimage_v1 . Note that it is not needed to jump
> back
> to offset 0x0 of the image, it is possible to jump directly at the
> reset
> label and save processing two instructions.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Dinh Nguyen <dinguyen@kernel.org>
> Cc: Chin Liang See <chin.liang.see@intel.com>
> ---
>  arch/arm/mach-socfpga/include/mach/boot0.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-socfpga/include/mach/boot0.h
> b/arch/arm/mach-socfpga/include/mach/boot0.h
> index d6b9435d33..06bbe27d2c 100644
> --- a/arch/arm/mach-socfpga/include/mach/boot0.h
> +++ b/arch/arm/mach-socfpga/include/mach/boot0.h
> @@ -18,10 +18,10 @@ _start:
>  	.word	0xcafec0d3;	/* Checksum, zero-pad */
>  	nop;
>  
> -	b reset;		/* SoCFPGA jumps here */
> -	nop;
> +	b reset;		/* SoCFPGA Gen5 jumps here */
>  	nop;
>  	nop;
> +	b reset;		/* SoCFPGA Gen10 trampoline */

Our mkpimage tools from SOCEDS is using 0x14 as offset. Wonder can we
standardize that by using 0x14 instead of proposed 0x18 in this patch?

Thanks
Chin Liang

>  #endif
>  
>  #endif /* __BOOT0_H */

  parent reply	other threads:[~2018-04-17  8:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-15 13:37 [U-Boot] [PATCH 1/5] ARM: socfpga: Add boot trampoline for Arria10 Marek Vasut
2018-04-15 13:37 ` [U-Boot] [PATCH 2/5] image: socfpga: Add SFP image version 1 definition Marek Vasut
2018-04-17  8:41   ` See, Chin Liang
2018-04-15 13:37 ` [U-Boot] [PATCH 3/5] tools: socfpga: Stop using global struct socfpga_image Marek Vasut
2018-04-17  8:43   ` See, Chin Liang
2018-04-15 13:37 ` [U-Boot] [PATCH 4/5] tools: socfpga: Add SFP image V1 support Marek Vasut
2018-04-15 13:37 ` [U-Boot] [PATCH 5/5] spl: socfpga: Generate Arria10 SFP header V1 Marek Vasut
2018-04-17  8:54   ` See, Chin Liang
2018-04-17  8:40 ` See, Chin Liang [this message]
2018-04-17  8:46   ` [U-Boot] [PATCH 1/5] ARM: socfpga: Add boot trampoline for Arria10 Marek Vasut
2018-04-17  8:52     ` See, Chin Liang
2018-04-17  9:01       ` Marek Vasut
2018-04-17  9:11         ` See, Chin Liang
2018-04-17  9:28           ` Marek Vasut
2018-04-19  5:51             ` See, Chin Liang
2018-04-19  9:06               ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1523954412.2582.13.camel@intel.com \
    --to=chin.liang.see@intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox