From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Fri, 20 Apr 2018 10:45:41 -0500 Subject: [U-Boot] [PATCH] board: freescale: ls1012ardb: Add command to switch QSPI bank In-Reply-To: References: <1523558902-23471-1-git-send-email-jagdish.gediya@nxp.com> <1524120459.5274.24.camel@buserror.net> <1524186628.5274.33.camel@buserror.net> Message-ID: <1524239141.5274.35.camel@buserror.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, 2018-04-20 at 03:16 +0000, Prabhakar Kushwaha wrote: > Thanks Scott for reviewing this patch > > > -----Original Message----- > > From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Scott > > Wood > > Sent: Friday, April 20, 2018 6:40 AM > > To: Calvin Johnson > > Cc: U-Boot Mailing List > > Subject: Re: [U-Boot] [PATCH] board: freescale: ls1012ardb: Add command to > > switch QSPI bank > > > > On Thu, 2018-04-19 at 14:09 +0530, Calvin Johnson wrote: > > > On Thu, Apr 19, 2018 at 12:17 PM, Scott Wood wrote: > > > > On Mon, 2018-04-16 at 08:40 +0530, Calvin Johnson wrote: > > > > > On Fri, Apr 13, 2018 at 12:18 AM, Jagdish Gediya > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > Add command "boot_bank X" to switch the boot bank to either > > > > > > 1 or 2. > > > > > > > > > > Are these functions required as this can be handled by new env > > > > > vars to switch banks? > > > > > > > > If you're going to add something new, a command is much more > > > > pleasant than env vars -- particularly if you stick to something > > > > like the familiar interfaces ("pix altbank", "qix altbank", etc), > > > > and include reporting of which bank was booted from if it's not > > > > there already. Of course, a fully standardized interface would be > > > > even better. > > > > > > Yes, a fully standardized generic interface supporting all similar > > > platforms with multiple banks > > > > And other boot sources such as NAND and MMC. > > > LS1012A has only one boot source i.e. QSPI I meant that if there is any effort to standardize the command it should support multiple boot sources, not just bank selection. -Scott