From: Chee, Tien Fong <tien.fong.chee@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/5] include: dma: Update the function description for dma_memcpy
Date: Mon, 4 Jun 2018 07:14:05 +0000 [thread overview]
Message-ID: <1528096445.67623.19.camel@intel.com> (raw)
In-Reply-To: <CAPnjgZ16FZZCkKXddPqZA8dvcvRw+9RztdMyOXxPOMDcYynarA@mail.gmail.com>
On Fri, 2018-06-01 at 08:25 -0600, Simon Glass wrote:
> Hi,
>
> On 31 May 2018 at 02:08, <tien.fong.chee@intel.com> wrote:
> >
> > From: Tien Fong Chee <tien.fong.chee@intel.com>
> >
> > Update the dma_memcpy description on return argument for DMA330
> > driver.
> >
> > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > ---
> > include/dma.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/dma.h b/include/dma.h
> > index 0a0c9dd..b825c1e 100644
> > --- a/include/dma.h
> > +++ b/include/dma.h
> > @@ -79,8 +79,8 @@ int dma_get_device(u32 transfer_type, struct
> > udevice **devp);
> > * @dst - destination pointer
> > * @src - souce pointer
> > * @len - data length to be copied
> > - * @return - on successful transfer returns no of bytes
> > - transferred and on failure return error code.
> > + * @return - on successful transfer returns no of bytes or
> > zero(for DMA330)
> > + * transferred and on failure return error code.
> This is a public API so you cannot change it just for one device. You
> can change the API for everyone if you like.
>
> But why would it want to return 0?
>
Because we only able to check the DMA tranferring status, full transfer
or failed. I can return the len argument user set if full tranfer is
finished.
> >
> > */
> > int dma_memcpy(struct udevice *dev, void *dst, void *src, size_t
> > len);
> >
> > --
> > 2.2.0
> >
> Regards,
> Simon
next prev parent reply other threads:[~2018-06-04 7:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 8:08 [U-Boot] [PATCH 0/5] Add DMA driver for DMA330 controller tien.fong.chee at intel.com
2018-05-31 8:08 ` [U-Boot] [PATCH 1/5] drivers: dma: Enable DMA-330 driver support tien.fong.chee at intel.com
2018-06-01 14:24 ` Simon Glass
2018-06-06 5:22 ` Chee, Tien Fong
2018-05-31 8:08 ` [U-Boot] [PATCH 2/5] drivers: dma: Add function to zeroes a range of destination such as memory tien.fong.chee at intel.com
2018-06-01 14:24 ` Simon Glass
2018-06-04 7:34 ` Chee, Tien Fong
2018-05-31 8:08 ` [U-Boot] [PATCH 3/5] drivers: dma: Factor out dma_get_device from DMA class function tien.fong.chee at intel.com
2018-06-01 14:25 ` Simon Glass
2018-05-31 8:08 ` [U-Boot] [PATCH 4/5] include: dma: Update the function description for dma_memcpy tien.fong.chee at intel.com
2018-06-01 14:25 ` Simon Glass
2018-06-04 7:14 ` Chee, Tien Fong [this message]
2018-06-08 21:59 ` Simon Glass
2018-06-11 5:05 ` Chee, Tien Fong
2018-05-31 8:08 ` [U-Boot] [PATCH 5/5] arm: dts: socfpga: stratix10: update pdma tien.fong.chee at intel.com
2018-06-01 14:25 ` Simon Glass
2018-06-04 7:01 ` Chee, Tien Fong
2018-07-09 18:03 ` Dinh Nguyen
2018-07-09 20:28 ` Marek Vasut
2018-07-10 13:11 ` Chee, Tien Fong
2018-07-10 13:37 ` Dinh Nguyen
2018-07-11 2:55 ` Chee, Tien Fong
2018-07-10 16:13 ` Marek Vasut
2018-05-31 9:24 ` [U-Boot] [PATCH 0/5] Add DMA driver for DMA330 controller Marek Vasut
2018-05-31 9:50 ` See, Chin Liang
2018-05-31 9:58 ` Marek Vasut
2018-06-04 6:47 ` Chee, Tien Fong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528096445.67623.19.camel@intel.com \
--to=tien.fong.chee@intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox