[U-Boot] [PATCH v3 3/3] common: Generic loader for file system

Tom Rini
2018-06-27T20:23:17Z

On Mon, Jun 25, 2018 at 09:58:51PM -0600, Simon Glass wrote:
> Hi,
>
> On 25 June 2018 at 07:28, <tien.fong.chee@intel.com> wrote:
> > From: Tien Fong Chee <tien.fong.chee@intel.com>
> >
> > This is file system generic loader which can be used to load
> > the file image from the storage into target such as memory.
> > The consumer driver would then use this loader to program whatever,
> > ie. the FPGA device.
> >
> > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > ---
> > drivers/misc/Kconfig | 10 ++
> > drivers/misc/Makefile | 1 +
> > drivers/misc/fs_loader.c | 238 +++++++++++++++++++++++++++++++++++++++++++++++
> > include/dm/uclass-id.h | 1 +
> > include/fs_loader.h | 28 ++++++
> > 5 files changed, 278 insertions(+)
> > create mode 100644 drivers/misc/fs_loader.c
> > create mode 100644 include/fs_loader.h
>
> This is definitely looking good. I think we need to figure out the
> binding to devices, to use phandles instead of strings. Also we need a
> sandbox driver and test.
>
> I'm a little worried that you are blazing a trail here, but it is a
> valuable trail :-)
>
> Tom, do you have any ideas / thoughts on the design?

If we're still able to support the various use cases, and everyone is
happier than before, that's good enough for me for now. We can always
evolve things as time goes on. Once there's tests of course :)

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180627/ba1fddcc/attachment.sig>