From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chee, Tien Fong Date: Tue, 10 Jul 2018 13:11:50 +0000 Subject: [U-Boot] [PATCH 5/5] arm: dts: socfpga: stratix10: update pdma In-Reply-To: References: <1527754134-164985-1-git-send-email-tien.fong.chee@intel.com> <1527754134-164985-6-git-send-email-tien.fong.chee@intel.com> <0592ff4c-1c46-05be-f61e-fda4e7f9f677@kernel.org> Message-ID: <1531228309.9725.7.camel@intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On Mon, 2018-07-09 at 22:28 +0200, Marek Vasut wrote: > On 07/09/2018 08:03 PM, Dinh Nguyen wrote: > > > > > > > > On 05/31/2018 03:08 AM, tien.fong.chee at intel.com wrote: > > > > > > From: Tien Fong Chee > > > > > > Update pdma properties for Stratix 10 > > > > > > Signed-off-by: Tien Fong Chee > > > --- > > >  arch/arm/dts/socfpga_stratix10.dtsi | 20 ++++++++++++++++++++ > > >  1 file changed, 20 insertions(+) > > > > > > diff --git a/arch/arm/dts/socfpga_stratix10.dtsi > > > b/arch/arm/dts/socfpga_stratix10.dtsi > > > index ccd3f32..311ba09 100644 > > > --- a/arch/arm/dts/socfpga_stratix10.dtsi > > > +++ b/arch/arm/dts/socfpga_stratix10.dtsi > > > @@ -82,6 +82,26 @@ > > >   ranges = <0 0 0 0xffffffff>; > > >   u-boot,dm-pre-reloc; > > >   > > > + amba { > > > + u-boot,dm-pre-reloc; > > > + compatible = "arm,amba-bus"; > > > + #address-cells = <1>; > > > + #size-cells = <1>; > > > + ranges; > > > + > > > + pdma: pdma at ffda0000 { > > > + u-boot,dm-pre-reloc; > > > + compatible = > > > "arm,pl330", "arm,dma330"; > > I think you got "arm,dma330" binding wrong. I don't see any binding > > with > > that name. Here https://patchwork.ozlabs.org/patch/923234/ . > I think the whole idea of using pl330 to scrub ECC DRAM is wrong. It > adds massive amount of code while a CPU can do the same and faster, > cfr > arria10. > I just measured the performance of initializing DRAM based on custodian arria10_sdmmc, which is around 16sec with 1GB. Using DMA to init the DDR, which is around 3-4sec for 2GB. I attached screenshot for the print out based on arria10_sdmmc custodian. -------------- next part -------------- A non-text attachment was scrubbed... Name: sdram_ecc_timing.png Type: image/png Size: 119153 bytes Desc: sdram_ecc_timing.png URL: