From mboxrd@z Thu Jan  1 00:00:00 1970
From: Trent Piepho <tpiepho@impinj.com>
Date: Mon, 16 Jul 2018 18:22:08 +0000
Subject: [U-Boot] [PATCH 06/11] mx7dsabresd: Add Windows boot support
 for iMX7 Sabre
In-Reply-To: <20180714001117.14584-7-hebeberm@microsoft.com>
References: <20180714001117.14584-1-hebeberm@microsoft.com>
 <20180714001117.14584-7-hebeberm@microsoft.com>
Message-ID: <1531765328.2283.101.camel@impinj.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Sat, 2018-07-14 at 00:11 +0000, Henry Beberman wrote:
> From: Henry Beberman <henry.beberman@microsoft.com>
> 
> This patch adds a new bootable configuration for Windows 10 IoT Core on
> the i.MX7 Dual Sabre board.
> 
> It enables SPL on the i.MX7 Sabre in order to support the FIT load of
> OP-TEE and U-Boot proper.
> 

> diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
> index f186120684..3fb9b72703 100644
> --- a/drivers/gpio/Makefile
> +++ b/drivers/gpio/Makefile
> @@ -7,10 +7,13 @@ ifndef CONFIG_SPL_BUILD
>  obj-$(CONFIG_DWAPB_GPIO)	+= dwapb_gpio.o
>  obj-$(CONFIG_AXP_GPIO)		+= axp_gpio.o
>  endif
> +
> +ifeq ($(CONFIG_$(SPL_TPL_)DM),y)
>  obj-$(CONFIG_DM_GPIO)		+= gpio-uclass.o
>  
>  obj-$(CONFIG_DM_PCA953X)	+= pca953x_gpio.o
>  obj-$(CONFIG_DM_74X164)		+= 74x164_gpio.o
> +endif

It doesn't look like this patch is specific to mx7 or Windows.  Perhaps
it should be in a different commit?

Also, the help text for SPL_DM says it turns on basic DM support in
SPL.  But not any specific hardware drivers.  Those all have additional
config options to turn them on.  It doesn't seems right to bundle a
selection of GPIO drivers along with CONFIG_SPL_DM.