public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ley Foon Tan <ley.foon.tan@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC][PATCH] cmd: clk: Add trivial implementation of clock dump for DM
Date: Thu, 09 Aug 2018 16:42:07 +0800	[thread overview]
Message-ID: <1533804127.38452.12.camel@intel.com> (raw)
In-Reply-To: <20180808201044.13522-1-marex@denx.de>

On Wed, 2018-08-08 at 22:10 +0200, Marek Vasut wrote:
> Add trivial implementation of the clk dump in case DM is enabled.
> This implementation just iterates over all the clock registered
> with the CLK uclass and prints their rate.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Chin Liang See <chin.liang.see@intel.com>
> Cc: Dinh Nguyen <dinguyen@kernel.org>
> Cc: Ley Foon Tan <ley.foon.tan@intel.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> ---
>  cmd/clk.c | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
> 
> diff --git a/cmd/clk.c b/cmd/clk.c
> index 73fb25092b..fd4231589c 100644
> --- a/cmd/clk.c
> +++ b/cmd/clk.c
> @@ -5,11 +5,48 @@
>  #include <common.h>
>  #include <command.h>
>  #include <clk.h>
> +#if defined(CONFIG_DM) && defined(CONFIG_CLK)
> +#include <dm.h>
> +#include <dm/device-internal.h>
> +#endif
>  
>  int __weak soc_clk_dump(void)
>  {
> +#if defined(CONFIG_DM) && defined(CONFIG_CLK)
> +	struct udevice *dev;
> +	struct uclass *uc;
> +	struct clk clk;
> +	int ret;
> +
> +	/* Device addresses start at 1 */
> +	ret = uclass_get(UCLASS_CLK, &uc);
> +	if (ret)
> +		return ret;
> +
> +	uclass_foreach_dev(dev, uc) {
> +		memset(&clk, 0, sizeof(clk));
> +		ret = device_probe(dev);
> +		if (ret) {
> +			printf("%-30.30s : ? Hz\n", dev->name);
> +			continue;
> +		}
> +
> +		ret = clk_request(dev, &clk);
> +		if (ret) {
> +			printf("%-30.30s : ? Hz\n", dev->name);
> +			continue;
> +		}
> +
> +		printf("%-30.30s : %lu Hz\n", dev->name,
> clk_get_rate(&clk));
> +
> +		clk_free(&clk);
> +	}
> +
> +	return 0;
> +#else
>  	puts("Not implemented\n");
>  	return 1;
> +#endif
>  }
>  
>  static int do_clk_dump(cmd_tbl_t *cmdtp, int flag, int argc,

Reviewed-by: Ley Foon Tan <ley.foon.tan@intel.com>

  reply	other threads:[~2018-08-09  8:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-08 20:10 [U-Boot] [RFC][PATCH] cmd: clk: Add trivial implementation of clock dump for DM Marek Vasut
2018-08-09  8:42 ` Ley Foon Tan [this message]
2018-10-02 11:20   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1533804127.38452.12.camel@intel.com \
    --to=ley.foon.tan@intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox