From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/6] tegra20: common: fix USB_EHCI_TXFIFO_THRESH value
Date: Mon, 17 Sep 2018 10:10:44 +0000 [thread overview]
Message-ID: <1537179039.16554.23.camel@toradex.com> (raw)
In-Reply-To: <20180916172301.25982-3-pbrobinson@gmail.com>
On Sun, 2018-09-16 at 18:22 +0100, Peter Robinson wrote:
> All other Tegra devices that define USB_EHCI_TXFIFO_THRESH use hex
> representation, fix tegra20 to be the same format.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> Cc: Tom Warren <twarren@nvidia.com>
> Cc: Stephen Warren <swarren@nvidia.com>
> ---
> include/configs/tegra20-common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/tegra20-common.h
> b/include/configs/tegra20-common.h
> index 7f0a5292c2e..3551616cd1e 100644
> --- a/include/configs/tegra20-common.h
> +++ b/include/configs/tegra20-common.h
> @@ -78,7 +78,7 @@
> * parameter, the default (2) causes occasional Data Buffer Errors
> in OUT
> * packets depending on the buffer address and size.
> */
> -#define CONFIG_USB_EHCI_TXFIFO_THRESH 10
> +#define CONFIG_USB_EHCI_TXFIFO_THRESH 0x10
I'm not quite sure about this one but believe that 10 on tegra20 vs.
0x10 on the others may actually be intentional. At least the same value
is used in the Linux kernel:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree
/drivers/usb/host/ehci-tegra.c#n567
Maybe one of them Warrens would know where exactly that
distinction/value came from?
However, I agree that using 0xa instead of 10 would make this more
clear.
> #define CONFIG_EHCI_IS_TDI
>
> #define CONFIG_SYS_NAND_SELF_INIT
next prev parent reply other threads:[~2018-09-17 10:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-16 17:22 [U-Boot] Some tegra cleanups and Kconfig migrations Peter Robinson
2018-09-16 17:22 ` [U-Boot] [PATCH 1/6] tegra: cleanup dangling comments in include/configs Peter Robinson
2018-09-17 10:00 ` Marcel Ziswiler
2018-09-16 17:22 ` [U-Boot] [PATCH 2/6] tegra20: common: fix USB_EHCI_TXFIFO_THRESH value Peter Robinson
2018-09-17 10:10 ` Marcel Ziswiler [this message]
2018-09-16 17:22 ` [U-Boot] [PATCH 3/6] Kconfig: tegra: Migrate SYS_I2C_TEGRA Peter Robinson
2018-09-17 13:52 ` Marcel Ziswiler
2018-09-16 17:23 ` [U-Boot] [PATCH 4/6] Kconfig: tegra: Migrate USB_EHCI_TEGRA Peter Robinson
2018-09-17 13:51 ` Marcel Ziswiler
2018-09-17 13:54 ` Marcel Ziswiler
2018-09-16 17:23 ` [U-Boot] [PATCH 5/6] Kconfig: tegra: Migrate TEGRA_KEYBOARD Peter Robinson
2018-09-17 13:59 ` Marcel Ziswiler
2018-09-16 17:23 ` [U-Boot] [PATCH 6/6] nyan-big: drop CONFIG_KEYBOARD Peter Robinson
2018-09-17 14:04 ` Marcel Ziswiler
2018-11-07 14:12 ` [U-Boot] Some tegra cleanups and Kconfig migrations Peter Robinson
2018-11-07 15:17 ` Tom Warren
2018-11-07 15:31 ` Tom Warren
2018-12-04 5:30 ` Peter Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537179039.16554.23.camel@toradex.com \
--to=marcel.ziswiler@toradex.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox