From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryder Lee Date: Thu, 25 Oct 2018 21:11:08 +0800 Subject: [U-Boot] [PATCH v2 01/18] tools: MediaTek: add MTK boot header generation to mkimage In-Reply-To: References: <255f549f5e8b5826ae28f9484d3505953b8d0fd3.1539326908.git.ryder.lee@mediatek.com> Message-ID: <1540473068.17532.2.camel@mtkswgap22> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, 2018-10-24 at 21:29 -0600, Simon Glass wrote: > Hi Ryder, > > On 12 October 2018 at 01:00, Ryder Lee wrote: > > This patch adds support for MTK boot image generation. > > > > Signed-off-by: Weijie Gao > > Signed-off-by: Ryder Lee > > --- > > Makefile | 22 ++ > > common/image.c | 1 + > > include/image.h | 1 + > > scripts/Makefile.spl | 11 + > > tools/Makefile | 1 + > > tools/mtkimage.c | 749 +++++++++++++++++++++++++++++++++++++++++++++++++++ > > tools/mtkimage.h | 199 ++++++++++++++ > > 7 files changed, 984 insertions(+) > > create mode 100644 tools/mtkimage.c > > create mode 100644 tools/mtkimage.h > > The mkimage stuff looks fine. > > But can you use binman for the pad/cat part of this? See for example > sunxi. - sunxi-u-boot.dtsi > > Also mtkimage.c is too close to mkimage.c - how about mtk_image.c ? > This looks great. I will switch to use binman in v3. Thanks Ryder