From: Ryder Lee <ryder.lee@mediatek.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 06/18] clk: MediaTek: add clock driver for MT7629 SoC.
Date: Mon, 5 Nov 2018 16:06:32 +0800 [thread overview]
Message-ID: <1541405192.7370.2.camel@mtkswgap22> (raw)
In-Reply-To: <CAPnjgZ26_o3Yc6=y-4+nmXQnD3+ALQ4CW7p9SmuETnpVjtGTUw@mail.gmail.com>
On Sat, 2018-11-03 at 00:08 -0600, Simon Glass wrote:
> Hi Ryder,
>
> On 2 November 2018 at 09:15, Ryder Lee <ryder.lee@mediatek.com> wrote:
> > This patch adds clock modules for MediaTek SoCs:
> > - Shared part: a common driver which contains the general operations
> > for plls, muxes, dividers and gates so that we can reuse it in future.
> >
> > - Specific SoC part: the group of structures used to hold the hardware
> > configuration for each SoC.
> >
> > We take MT7629 as an example to demonstrate how to implement driver if
> > any other MediaTek chips would like to use it.
> >
> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> > ---
> > drivers/clk/Makefile | 1 +
> > drivers/clk/mediatek/Makefile | 6 +
> > drivers/clk/mediatek/clk-mt7629.c | 709 ++++++++++++++++++++++++++++++++++++++
> > drivers/clk/mediatek/clk-mtk.c | 492 ++++++++++++++++++++++++++
> > drivers/clk/mediatek/clk-mtk.h | 153 ++++++++
> > 5 files changed, 1361 insertions(+)
> > create mode 100644 drivers/clk/mediatek/Makefile
> > create mode 100644 drivers/clk/mediatek/clk-mt7629.c
> > create mode 100644 drivers/clk/mediatek/clk-mtk.c
> > create mode 100644 drivers/clk/mediatek/clk-mtk.h
>
> Please add coments to the structs and functions in the header file.
> Also put a _common prefix on the functions that are called from other
> files.
>
> Otherwise:
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> Regards,
> Simon
Got it. I will send a new series soon.
Ryder
next prev parent reply other threads:[~2018-11-05 8:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 15:15 [U-Boot] [PATCH v3 00/18] Add U-Boot support for MediaTek SoCs - MT7623n & MT7629 Ryder Lee
2018-11-02 15:15 ` [U-Boot] [PATCH v3 01/18] tools: MediaTek: add MTK boot header generation to mkimage Ryder Lee
2018-11-03 6:08 ` Simon Glass
2018-11-05 8:05 ` Ryder Lee
2018-11-02 15:15 ` [U-Boot] [PATCH v3 02/18] arm: dts: MediaTek: add device tree for MT7629 Ryder Lee
2018-11-02 15:15 ` [U-Boot] [PATCH v3 03/18] arm: dts: MediaTek: add device tree for MT7623 Ryder Lee
2018-11-02 15:15 ` [U-Boot] [PATCH v3 04/18] arm: MediaTek: add basic support for MT7629 boards Ryder Lee
2018-11-03 6:08 ` Simon Glass
2018-11-02 15:15 ` [U-Boot] [PATCH v3 05/18] arm: MediaTek: add basic support for MT7623 boards Ryder Lee
2018-11-02 15:15 ` [U-Boot] [PATCH v3 06/18] clk: MediaTek: add clock driver for MT7629 SoC Ryder Lee
2018-11-03 6:08 ` Simon Glass
2018-11-05 8:06 ` Ryder Lee [this message]
2018-11-02 15:15 ` [U-Boot] [PATCH v3 07/18] clk: MediaTek: add clock driver for MT7623 SoC Ryder Lee
2018-11-02 15:15 ` [U-Boot] [PATCH v3 08/18] timer: MediaTek: add timer driver for MediaTek SoCs Ryder Lee
2018-11-02 15:15 ` [U-Boot] [PATCH v3 09/18] watchdog: MediaTek: add watchdog " Ryder Lee
2018-11-02 15:15 ` [U-Boot] [PATCH v3 10/18] pinctrl: MediaTek: add pinctrl driver for MT7629 SoC Ryder Lee
2018-11-03 6:08 ` Simon Glass
2018-11-02 15:15 ` [U-Boot] [PATCH v3 11/18] pinctrl: MediaTek: add pinctrl driver for MT7623 SoC Ryder Lee
2018-11-03 6:08 ` Simon Glass
2018-11-02 15:15 ` [U-Boot] [PATCH v3 12/18] power domain: MediaTek: add power domain driver for MT7629 SoC Ryder Lee
2018-11-02 15:15 ` [U-Boot] [PATCH v3 13/18] power domain: MediaTek: add power domain driver for MT7623 SoC Ryder Lee
2018-11-02 15:15 ` [U-Boot] [PATCH v3 14/18] serial: 16550: allow the driver to support MediaTek serial Ryder Lee
2018-11-03 6:09 ` Simon Glass
2018-11-05 2:20 ` Ryder Lee
2018-11-05 8:37 ` Ryder Lee
2018-11-06 2:48 ` Weijie Gao
2018-11-13 19:53 ` Simon Glass
2018-11-02 15:15 ` [U-Boot] [PATCH v3 15/18] ram: MediaTek: add DDR3 driver for MT7629 SoC Ryder Lee
2018-11-02 15:15 ` [U-Boot] [PATCH v3 16/18] mmc: mtk-sd: add SD/MMC host controller driver for MT7623 SoC Ryder Lee
2018-11-02 15:15 ` [U-Boot] [PATCH v3 17/18] doc: README.mediatek: Add a simple README for MediaTek Ryder Lee
2018-11-03 6:08 ` Simon Glass
2018-11-02 15:15 ` [U-Boot] [PATCH v3 18/18] MAINTAINERS: add an entry " Ryder Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541405192.7370.2.camel@mtkswgap22 \
--to=ryder.lee@mediatek.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox