From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryder Lee Date: Mon, 5 Nov 2018 16:06:32 +0800 Subject: [U-Boot] [PATCH v3 06/18] clk: MediaTek: add clock driver for MT7629 SoC. In-Reply-To: References: <92863eb6d1da44954a45273c430241d465d4962e.1541171496.git.ryder.lee@mediatek.com> Message-ID: <1541405192.7370.2.camel@mtkswgap22> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sat, 2018-11-03 at 00:08 -0600, Simon Glass wrote: > Hi Ryder, > > On 2 November 2018 at 09:15, Ryder Lee wrote: > > This patch adds clock modules for MediaTek SoCs: > > - Shared part: a common driver which contains the general operations > > for plls, muxes, dividers and gates so that we can reuse it in future. > > > > - Specific SoC part: the group of structures used to hold the hardware > > configuration for each SoC. > > > > We take MT7629 as an example to demonstrate how to implement driver if > > any other MediaTek chips would like to use it. > > > > Signed-off-by: Ryder Lee > > --- > > drivers/clk/Makefile | 1 + > > drivers/clk/mediatek/Makefile | 6 + > > drivers/clk/mediatek/clk-mt7629.c | 709 ++++++++++++++++++++++++++++++++++++++ > > drivers/clk/mediatek/clk-mtk.c | 492 ++++++++++++++++++++++++++ > > drivers/clk/mediatek/clk-mtk.h | 153 ++++++++ > > 5 files changed, 1361 insertions(+) > > create mode 100644 drivers/clk/mediatek/Makefile > > create mode 100644 drivers/clk/mediatek/clk-mt7629.c > > create mode 100644 drivers/clk/mediatek/clk-mtk.c > > create mode 100644 drivers/clk/mediatek/clk-mtk.h > > Please add coments to the structs and functions in the header file. > Also put a _common prefix on the functions that are called from other > files. > > Otherwise: > > Reviewed-by: Simon Glass > > Regards, > Simon Got it. I will send a new series soon. Ryder