From: Ryder Lee <ryder.lee@mediatek.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 14/18] serial: 16550: allow the driver to support MediaTek serial
Date: Wed, 14 Nov 2018 09:32:40 +0800 [thread overview]
Message-ID: <1542159160.6150.3.camel@mtkswgap22> (raw)
In-Reply-To: <CAPnjgZ3d9zd3Vsgrn339GKRBOdFvq9MZjF7r0-NM987673HanQ@mail.gmail.com>
On Tue, 2018-11-13 at 11:53 -0800, Simon Glass wrote:
> Hi Ryder,
>
> On 6 November 2018 at 01:47, Ryder Lee <ryder.lee@mediatek.com> wrote:
> > This patch adds an extra operation in ns16550.c to suuport MediaTek
> > SoCs as we have a highspeed register which influences the calcualtion
> > of the divisor.
> >
> > Note that we don't support the baudrate greater than 115200 currently.
> >
> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> > Tested-by: Matthias Brugger <matthias.bgg@gmail.com>
> > Reviewed-by: Simon Glass <sjg@chromium.org>
> > ---
> > Changes since v4: None
> >
> > @Simon
> > We have tried the compatible string, but it made the ns16550 driver more complicated.
> > To use the compatible string we have to add a new field in ns16550_platdata, and change
> > the flow of ns16550_serial_probe().
> >
> > Moreover, it's totally useless for debug uart. At present using a macro is the easiest way here.
> >
> > What do you think?
> > ---
> > drivers/serial/ns16550.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
>
> Please see my reply to the other thread. We should not have
> arch-specific code in generic drivers.
>
> Sorry for not replying earlier on that.
>
OK.
BTW, can you (or Tom) please take the other patches through your tree?
Ryder
next prev parent reply other threads:[~2018-11-14 1:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 8:47 [U-Boot] [PATCH v4 00/18] Add U-Boot support for MediaTek SoCs - MT7623n & MT7629 Ryder Lee
2018-11-06 8:47 ` [U-Boot] [PATCH v4 01/18] tools: MediaTek: add MTK boot header generation to mkimage Ryder Lee
2018-11-14 17:27 ` Fabien Parent
2018-11-06 8:47 ` [U-Boot] [PATCH v4 02/18] arm: dts: MediaTek: add device tree for MT7629 Ryder Lee
2018-11-06 8:47 ` [U-Boot] [PATCH v4 03/18] arm: dts: MediaTek: add device tree for MT7623 Ryder Lee
2018-11-06 8:47 ` [U-Boot] [PATCH v4 04/18] arm: MediaTek: add basic support for MT7629 boards Ryder Lee
2018-11-06 8:47 ` [U-Boot] [PATCH v4 05/18] arm: MediaTek: add basic support for MT7623 boards Ryder Lee
2018-11-06 8:47 ` [U-Boot] [PATCH v4 06/18] clk: MediaTek: add clock driver for MT7629 SoC Ryder Lee
2018-11-06 8:47 ` [U-Boot] [PATCH v4 07/18] clk: MediaTek: add clock driver for MT7623 SoC Ryder Lee
2018-11-06 8:47 ` [U-Boot] [PATCH v4 08/18] timer: MediaTek: add timer driver for MediaTek SoCs Ryder Lee
2018-11-06 8:47 ` [U-Boot] [PATCH v4 09/18] watchdog: MediaTek: add watchdog " Ryder Lee
2018-11-06 8:47 ` [U-Boot] [PATCH v4 10/18] pinctrl: MediaTek: add pinctrl driver for MT7629 SoC Ryder Lee
2018-11-06 8:47 ` [U-Boot] [PATCH v4 11/18] pinctrl: MediaTek: add pinctrl driver for MT7623 SoC Ryder Lee
2018-11-06 8:47 ` [U-Boot] [PATCH v4 12/18] power domain: MediaTek: add power domain driver for MT7629 SoC Ryder Lee
2018-11-06 8:47 ` [U-Boot] [PATCH v4 13/18] power domain: MediaTek: add power domain driver for MT7623 SoC Ryder Lee
2018-11-06 8:47 ` [U-Boot] [PATCH v4 14/18] serial: 16550: allow the driver to support MediaTek serial Ryder Lee
2018-11-13 19:53 ` Simon Glass
2018-11-14 1:32 ` Ryder Lee [this message]
2018-11-15 19:59 ` Simon Glass
2018-11-16 14:30 ` Tom Rini
2018-11-19 0:39 ` Weijie Gao
2018-11-06 8:47 ` [U-Boot] [PATCH v4 15/18] ram: MediaTek: add DDR3 driver for MT7629 SoC Ryder Lee
2018-11-06 8:47 ` [U-Boot] [PATCH v4 16/18] mmc: mtk-sd: add SD/MMC host controller driver for MT7623 SoC Ryder Lee
2018-11-06 8:47 ` [U-Boot] [PATCH v4 17/18] doc: README.mediatek: Add a simple README for MediaTek Ryder Lee
2018-11-06 16:20 ` Frank Wunderlich
2018-11-06 8:47 ` [U-Boot] [PATCH v4 18/18] MAINTAINERS: add an entry " Ryder Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542159160.6150.3.camel@mtkswgap22 \
--to=ryder.lee@mediatek.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox