[U-Boot] [PATCH 5/9] ARM: socfpga: Add SPL fitImage config match

Marek Vasut
2018-11-23T12:34:46Z

On 11/23/2018 11:05 AM, Chee, Tien Fong wrote:
> On Wed, 2018-11-21 at 15:21 +0100, Marek Vasut wrote:
>> On 11/21/2018 11:41 AM, tien.fong.chee at intel.com wrote:
>>>
>>> From: Tien Fong Chee <tien.fong.chee@intel.com>
>>>
>>> Add empty SPL fitImage configuration match. This can be extended
>>> if there is ever need to support multiple boards with single SFP
>>> image.
>>>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>> It's missing your SoB line, but again, why is this patch needed ?
> This patch i also cherry picked from sdmmc_next custodian, and i didn't
> made any changes, so i still need SoB?

Yes

> Without this patch, compiling failed with error"/uboot-
> socfpga/common/common_fit.c:66: undefined reference to
> `board_fit_config_name_match'"

Sure, it will fail. Let's continue the discussion at 4/9.

>>> ---
>>>  arch/arm/mach-socfpga/spl_a10.c |   10 ++++++++++
>>>  1 files changed, 10 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-socfpga/spl_a10.c b/arch/arm/mach-
>>> socfpga/spl_a10.c
>>> index 67a4fac..2baeba6 100644
>>> --- a/arch/arm/mach-socfpga/spl_a10.c
>>> +++ b/arch/arm/mach-socfpga/spl_a10.c
>>> @@ -148,3 +148,13 @@ void board_init_f(ulong dummy)
>>>   config_dedicated_pins(gd->fdt_blob);
>>>   WATCHDOG_RESET();
>>>  }
>>> +
>>> +#ifdef CONFIG_SPL_LOAD_FIT
>>> +int board_fit_config_name_match(const char *name)
>>> +{
>>> + /* Just empty function now - can't decide what to choose
>>> */
>>> + debug("%s: %s\n", __func__, name);
>>> +
>>> + return 0;
>>> +}
>>> +#endif
>>>

--
Best regards,
Marek Vasut