From: Chee, Tien Fong <tien.fong.chee@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add support for initializing MMC
Date: Thu, 13 Dec 2018 16:22:29 +0000 [thread overview]
Message-ID: <1544718148.9766.1.camel@intel.com> (raw)
In-Reply-To: <1544715177-30134-1-git-send-email-tien.fong.chee@intel.com>
On Thu, 2018-12-13 at 23:32 +0800, tien.fong.chee at intel.com wrote:
> From: Tien Fong Chee <tien.fong.chee@intel.com>
>
> Firmware loader would encounter problem if the MMC is accessed before
> initializing it. This patch would adding the support of initializing
> MMC before the MMC is accessed by firmware loader.
>
> Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> ---
> drivers/misc/fs_loader.c | 33 ++++++++++++++++++++++++++++++++-
> 1 files changed, 32 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/misc/fs_loader.c b/drivers/misc/fs_loader.c
> index 57a14a3..675f625 100644
> --- a/drivers/misc/fs_loader.c
> +++ b/drivers/misc/fs_loader.c
> @@ -12,6 +12,7 @@
> #include <linux/string.h>
> #include <mapmem.h>
> #include <malloc.h>
> +#include <mmc.h>
> #include <spl.h>
>
> DECLARE_GLOBAL_DATA_PTR;
> @@ -221,6 +222,7 @@ static int fs_loader_ofdata_to_platdata(struct
> udevice *dev)
> {
> const char *fs_loader_path;
> u32 phandlepart[2];
> + struct device_platdata *plat = NULL;
>
> fs_loader_path = ofnode_get_chosen_prop("firmware-loader");
>
> @@ -229,7 +231,6 @@ static int fs_loader_ofdata_to_platdata(struct
> udevice *dev)
>
> fs_loader_node = ofnode_path(fs_loader_path);
> if (ofnode_valid(fs_loader_node)) {
> - struct device_platdata *plat;
> plat = dev->platdata;
>
> if (!ofnode_read_u32_array(fs_loader_node,
> @@ -247,6 +248,36 @@ static int fs_loader_ofdata_to_platdata(struct
> udevice *dev)
> }
> }
>
I just realized this portion of codes should be moved to polling
function. I will send out another patch tomorrow.
> +#ifdef CONFIG_MMC
> + int ret;
> +
> + ret = mmc_initialize(NULL);
> + if (ret) {
> + debug("MMC: could not initialize mmc. error: %d\n",
> ret);
> +
> + return ret;
> + }
> +
> + if (plat->phandlepart.phandle) {
> + ofnode node = ofnode_get_by_phandle(plat-
> >phandlepart.phandle);
> +
> + struct udevice *mmc_dev = NULL;
> +
> + ret = device_get_global_by_ofnode(node, &mmc_dev);
> + if (!ret) {
> + struct mmc *mmc = mmc_get_mmc_dev(mmc_dev);
> +
> + ret = mmc_init(mmc);
> + if (ret) {
> + debug("MMC: mmc init failed with
> error: %d\n",
> + ret);
> +
> + return ret;
> + }
> + }
> + }
> +#endif
> +
> return 0;
> }
>
next prev parent reply other threads:[~2018-12-13 16:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 15:32 [U-Boot] [PATCH] Add support for initializing MMC tien.fong.chee at intel.com
2018-12-13 16:22 ` Chee, Tien Fong [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-12-14 6:53 tien.fong.chee at intel.com
2018-12-21 8:25 ` Chee, Tien Fong
2018-12-21 17:16 ` Simon Glass
2018-12-21 17:50 ` Chee, Tien Fong
2018-12-22 20:51 ` Simon Glass
2018-12-24 3:41 ` Chee, Tien Fong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544718148.9766.1.camel@intel.com \
--to=tien.fong.chee@intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox