public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Chee, Tien Fong <tien.fong.chee@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] spl: fat/fs: Add control to build FS EXT4 in SPL
Date: Fri, 18 Jan 2019 04:22:11 +0000	[thread overview]
Message-ID: <1547785329.9980.1.camel@intel.com> (raw)
In-Reply-To: <20190117122326.GP27429@bill-the-cat>

On Thu, 2019-01-17 at 07:23 -0500, Tom Rini wrote:
> On Thu, Jan 17, 2019 at 03:01:49PM +0800, tien.fong.chee at intel.com
> wrote:
> 
> > 
> > From: Tien Fong Chee <tien.fong.chee@intel.com>
> > 
> > CONFIG_SPL_EXT_SUPPORT can be used to include/exclude the FS EXT4
> > from
> > SPL build. Excluding the FS EXT4 from SPL build can help to save
> > 20KiB
> > memory.
> > 
> > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > ---
> >  fs/fs.c |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> > 
> > diff --git a/fs/fs.c b/fs/fs.c
> > index 0b8088b..252e2f5 100644
> > --- a/fs/fs.c
> > +++ b/fs/fs.c
> > @@ -184,7 +184,9 @@ static struct fstype_info fstypes[] = {
> >  		.closedir = fat_closedir,
> >  	},
> >  #endif
> > -#ifdef CONFIG_FS_EXT4
> > +/* #ifdef CONFIG_FS_EXT4 */
> > +#if (!defined(CONFIG_SPL_BUILD) && defined(CONFIG_FS_EXT4)) || \
> > +	(defined(CONFIG_SPL_BUILD) &&
> > defined(CONFIG_SPL_EXT_SUPPORT))
> >  	{
> >  		.fstype = FS_TYPE_EXT,
> >  		.name = "ext4",
> This should be CONFIG_IS_ENABLED(FS_EXT4) in a 2/2 patch with a 1/2
> patch renaming SPL_EXT_SUPPORT TO SPL_FS_EXT4, thanks!
Okay.
> 

      reply	other threads:[~2019-01-18  4:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17  7:01 [U-Boot] [PATCH] spl: fat/fs: Add control to build FS EXT4 in SPL tien.fong.chee at intel.com
2019-01-17 12:23 ` Tom Rini
2019-01-18  4:22   ` Chee, Tien Fong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1547785329.9980.1.camel@intel.com \
    --to=tien.fong.chee@intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox