* [U-Boot] [PATCH] spl: fat/fs: Add control to build FS EXT4 in SPL
@ 2019-01-17 7:01 tien.fong.chee at intel.com
2019-01-17 12:23 ` Tom Rini
0 siblings, 1 reply; 3+ messages in thread
From: tien.fong.chee at intel.com @ 2019-01-17 7:01 UTC (permalink / raw)
To: u-boot
From: Tien Fong Chee <tien.fong.chee@intel.com>
CONFIG_SPL_EXT_SUPPORT can be used to include/exclude the FS EXT4 from
SPL build. Excluding the FS EXT4 from SPL build can help to save 20KiB
memory.
Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
---
fs/fs.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fs/fs.c b/fs/fs.c
index 0b8088b..252e2f5 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -184,7 +184,9 @@ static struct fstype_info fstypes[] = {
.closedir = fat_closedir,
},
#endif
-#ifdef CONFIG_FS_EXT4
+/* #ifdef CONFIG_FS_EXT4 */
+#if (!defined(CONFIG_SPL_BUILD) && defined(CONFIG_FS_EXT4)) || \
+ (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SPL_EXT_SUPPORT))
{
.fstype = FS_TYPE_EXT,
.name = "ext4",
--
1.7.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] spl: fat/fs: Add control to build FS EXT4 in SPL
2019-01-17 7:01 [U-Boot] [PATCH] spl: fat/fs: Add control to build FS EXT4 in SPL tien.fong.chee at intel.com
@ 2019-01-17 12:23 ` Tom Rini
2019-01-18 4:22 ` Chee, Tien Fong
0 siblings, 1 reply; 3+ messages in thread
From: Tom Rini @ 2019-01-17 12:23 UTC (permalink / raw)
To: u-boot
On Thu, Jan 17, 2019 at 03:01:49PM +0800, tien.fong.chee at intel.com wrote:
> From: Tien Fong Chee <tien.fong.chee@intel.com>
>
> CONFIG_SPL_EXT_SUPPORT can be used to include/exclude the FS EXT4 from
> SPL build. Excluding the FS EXT4 from SPL build can help to save 20KiB
> memory.
>
> Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> ---
> fs/fs.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/fs/fs.c b/fs/fs.c
> index 0b8088b..252e2f5 100644
> --- a/fs/fs.c
> +++ b/fs/fs.c
> @@ -184,7 +184,9 @@ static struct fstype_info fstypes[] = {
> .closedir = fat_closedir,
> },
> #endif
> -#ifdef CONFIG_FS_EXT4
> +/* #ifdef CONFIG_FS_EXT4 */
> +#if (!defined(CONFIG_SPL_BUILD) && defined(CONFIG_FS_EXT4)) || \
> + (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SPL_EXT_SUPPORT))
> {
> .fstype = FS_TYPE_EXT,
> .name = "ext4",
This should be CONFIG_IS_ENABLED(FS_EXT4) in a 2/2 patch with a 1/2
patch renaming SPL_EXT_SUPPORT TO SPL_FS_EXT4, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190117/d63b9445/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] spl: fat/fs: Add control to build FS EXT4 in SPL
2019-01-17 12:23 ` Tom Rini
@ 2019-01-18 4:22 ` Chee, Tien Fong
0 siblings, 0 replies; 3+ messages in thread
From: Chee, Tien Fong @ 2019-01-18 4:22 UTC (permalink / raw)
To: u-boot
On Thu, 2019-01-17 at 07:23 -0500, Tom Rini wrote:
> On Thu, Jan 17, 2019 at 03:01:49PM +0800, tien.fong.chee at intel.com
> wrote:
>
> >
> > From: Tien Fong Chee <tien.fong.chee@intel.com>
> >
> > CONFIG_SPL_EXT_SUPPORT can be used to include/exclude the FS EXT4
> > from
> > SPL build. Excluding the FS EXT4 from SPL build can help to save
> > 20KiB
> > memory.
> >
> > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > ---
> > fs/fs.c | 4 +++-
> > 1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/fs/fs.c b/fs/fs.c
> > index 0b8088b..252e2f5 100644
> > --- a/fs/fs.c
> > +++ b/fs/fs.c
> > @@ -184,7 +184,9 @@ static struct fstype_info fstypes[] = {
> > .closedir = fat_closedir,
> > },
> > #endif
> > -#ifdef CONFIG_FS_EXT4
> > +/* #ifdef CONFIG_FS_EXT4 */
> > +#if (!defined(CONFIG_SPL_BUILD) && defined(CONFIG_FS_EXT4)) || \
> > + (defined(CONFIG_SPL_BUILD) &&
> > defined(CONFIG_SPL_EXT_SUPPORT))
> > {
> > .fstype = FS_TYPE_EXT,
> > .name = "ext4",
> This should be CONFIG_IS_ENABLED(FS_EXT4) in a 2/2 patch with a 1/2
> patch renaming SPL_EXT_SUPPORT TO SPL_FS_EXT4, thanks!
Okay.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-18 4:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-17 7:01 [U-Boot] [PATCH] spl: fat/fs: Add control to build FS EXT4 in SPL tien.fong.chee at intel.com
2019-01-17 12:23 ` Tom Rini
2019-01-18 4:22 ` Chee, Tien Fong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox