From: "Heiko Stübner" <heiko@sntech.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] rockchip: derive ethaddr from cpuid
Date: Wed, 10 Jul 2019 14:53:18 +0200 [thread overview]
Message-ID: <15481632.MWfDn8uRTV@diego> (raw)
In-Reply-To: <8602679.MHfQdYsYPO@solembum>
Hi Rohan,
Am Mittwoch, 10. Juli 2019, 14:08:31 CEST schrieb Rohan Garg:
> Hey Heiko
> > Also, that code looks pretty much like the same in rk3399-puma.
> >
> > So maybe it might be good to have this in a common location so
> > more boards can access common code instead of duplicating that
> > whole function numerous times?
>
> Sounds good to me, do you have any recommendations where something like this
> would live?
From a cursory glance, it looks like most Rockchip socs have that cpu-id
value in the efuse (I checked rk3288, rk3399, rk3328 ... rk3368 efuse looks
similar but I'm not sure yet if it also has that id value).
So in any case I'd suggest somewhere in mach-rockchip, so that all
Rockchip socs can profit from that if they want.
It might be good to separate the cpu-id reading from the serial-generation
though, to parameterize the offset+length.
cpu_id = rockchip_cpuid_from_efuse(offset, length);
//containing the efuse related code
rockchip_cpuid_set(cpu_id);
//containing the calculations and env-setting
Heiko
next prev parent reply other threads:[~2019-07-10 12:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 10:37 [U-Boot] [PATCH] rockchip: derive ethaddr from cpuid Rohan Garg
2019-07-10 6:37 ` Kever Yang
2019-07-10 10:03 ` Heiko Stübner
2019-07-10 12:08 ` Rohan Garg
2019-07-10 12:53 ` Heiko Stübner [this message]
2019-07-10 12:07 ` Rohan Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15481632.MWfDn8uRTV@diego \
--to=heiko@sntech.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox