public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Chee, Tien Fong <tien.fong.chee@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fpga: Replace char * with const char * for filename
Date: Wed, 20 Feb 2019 12:03:11 +0000	[thread overview]
Message-ID: <1550664191.19744.0.camel@intel.com> (raw)
In-Reply-To: <ce05ec30-f0ae-dc39-e063-de082a41562c@xilinx.com>

On Mon, 2019-02-18 at 13:27 +0100, Michal Simek wrote:
> On 15. 02. 19 8:57, tien.fong.chee at intel.com wrote:
> > 
> > From: Tien Fong Chee <tien.fong.chee@intel.com>
> > 
> > Ensure the string for filename is always constant, otherwise it can
> > be
> > corrupted by the writing.
> Have you reach any issue with it?
Just to resolve the compiler warning about missing of const.
> 
> > 
> > 
> > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > ---
> >  drivers/fpga/zynqpl.c |    3 ++-
> >  include/fpga.h        |    2 +-
> >  2 files changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/fpga/zynqpl.c b/drivers/fpga/zynqpl.c
> > index 499310d..683cf14 100644
> > --- a/drivers/fpga/zynqpl.c
> > +++ b/drivers/fpga/zynqpl.c
> > @@ -421,7 +421,8 @@ static int zynq_loadfs(xilinx_desc *desc, const
> > void *buf, size_t bsize,
> >  	loff_t blocksize, actread;
> >  	loff_t pos = 0;
> >  	int fstype;
> > -	char *interface, *dev_part, *filename;
> > +	char *interface, *dev_part;
> > +	const char *filename;
> >  
> >  	blocksize = fsinfo->blocksize;
> >  	interface = fsinfo->interface;
> > diff --git a/include/fpga.h b/include/fpga.h
> > index 195f0bd..51de5c5 100644
> > --- a/include/fpga.h
> > +++ b/include/fpga.h
> > @@ -41,7 +41,7 @@ typedef struct {                /* typedef
> > fpga_desc */
> >  	unsigned int blocksize;
> >  	char *interface;
> >  	char *dev_part;
> > -	char *filename;
> > +	const char *filename;
> >  	int fstype;
> >  } fpga_fs_info;
> >  
> > 
> Anyway looks good applied.
> 
> Thanks,
> Michal

  reply	other threads:[~2019-02-20 12:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15  7:57 [U-Boot] [PATCH] fpga: Replace char * with const char * for filename tien.fong.chee at intel.com
2019-02-18 12:27 ` Michal Simek
2019-02-20 12:03   ` Chee, Tien Fong [this message]
2019-02-20 13:27     ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1550664191.19744.0.camel@intel.com \
    --to=tien.fong.chee@intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox