From: Chee, Tien Fong <tien.fong.chee@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v11 3/9] ARM: socfpga: Cleaning up the messages
Date: Thu, 7 Mar 2019 07:57:18 +0000 [thread overview]
Message-ID: <1551945437.9744.18.camel@intel.com> (raw)
In-Reply-To: <1227471b-aede-3e32-5fdc-e94d6004bf95@kernel.org>
On Tue, 2019-03-05 at 22:31 -0600, Dinh Nguyen wrote:
>
> On 3/5/19 10:23 AM, tien.fong.chee at intel.com wrote:
> >
> > From: Tien Fong Chee <tien.fong.chee@intel.com>
> >
> > Ensure the comment and debug messages are always consistent with
> > the rest.
> The rest of what? This patch seems unnecessary to me.
This patch is mainly to change all existing debug messages with prefix
"FPGA:" and ensure uppercase for 1st character in all messages inside
FPGA driver.
Thanks,
TF.
>
> >
> >
> > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > ---
> > drivers/fpga/socfpga_arria10.c | 13 +++++++------
> > 1 file changed, 7 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/fpga/socfpga_arria10.c
> > b/drivers/fpga/socfpga_arria10.c
> > index 114dd910ab..b0abe1955c 100644
> > --- a/drivers/fpga/socfpga_arria10.c
> > +++ b/drivers/fpga/socfpga_arria10.c
> > @@ -94,7 +94,7 @@ int fpgamgr_wait_early_user_mode(void)
> > i++;
> > }
> >
> > - debug("Additional %i sync word needed\n", i);
> > + debug("FPGA: Additional %i sync word needed\n", i);
> >
> > /* restoring original CDRATIO */
> > fpgamgr_set_cd_ratio(cd_ratio);
> > @@ -172,9 +172,10 @@ static int
> > fpgamgr_set_cdratio_cdwidth(unsigned int cfg_width, u32 *rbf_data,
> > compress = (rbf_data[COMPRESSION_OFFSET] >> 1) & 1;
> > compress = !compress;
> >
> > - debug("header word %d = %08x\n", 69, rbf_data[69]);
> > - debug("header word %d = %08x\n", 229, rbf_data[229]);
> > - debug("read from rbf header: encrypt=%d compress=%d\n",
> > encrypt, compress);
> > + debug("FPGA: Header word %d = %08x.\n", 69, rbf_data[69]);
> > + debug("FPGA: Header word %d = %08x.\n", 229,
> > rbf_data[229]);
> > + debug("FPGA: Read from rbf header: encrypt=%d
> > compress=%d.\n", encrypt,
> > + compress);
> >
> > /*
> > * from the register map description of cdratio in
> > imgcfg_ctrl_02:
> > @@ -455,10 +456,10 @@ int socfpga_load(Altera_desc *desc, const
> > void *rbf_data, size_t rbf_size)
> > {
> > int status;
> >
> > - /* disable all signals from hps peripheral controller to
> > fpga */
> > + /* Disable all signals from hps peripheral controller to
> > fpga */
> > writel(0, &system_manager_base->fpgaintf_en_global);
> >
> > - /* disable all axi bridge (hps2fpga, lwhps2fpga &
> > fpga2hps) */
> > + /* Disable all axi bridge (hps2fpga, lwhps2fpga &
> > fpga2hps) */
> > socfpga_bridges_reset();
> >
> > /* Initialize the FPGA Manager */
> >
next prev parent reply other threads:[~2019-03-07 7:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 16:23 [U-Boot] [PATCH v11 0/9] Add support for loading FPGA bitstream tien.fong.chee at intel.com
2019-03-05 16:23 ` [U-Boot] [PATCH v11 1/9] ARM: socfpga: Description on FPGA bitstream type and file name for Arria 10 tien.fong.chee at intel.com
2019-03-05 19:12 ` Dinh Nguyen
2019-03-07 7:51 ` Chee, Tien Fong
2019-03-07 8:18 ` Marek Vasut
2019-03-07 8:30 ` Chee, Tien Fong
2019-03-07 8:38 ` Marek Vasut
2019-03-07 8:56 ` Chee, Tien Fong
2019-03-05 16:23 ` [U-Boot] [PATCH v11 2/9] ARM: socfpga: Add default FPGA bitstream fitImage for Arria10 SoCDK tien.fong.chee at intel.com
2019-03-05 16:23 ` [U-Boot] [PATCH v11 3/9] ARM: socfpga: Cleaning up the messages tien.fong.chee at intel.com
2019-03-06 4:31 ` Dinh Nguyen
2019-03-07 7:57 ` Chee, Tien Fong [this message]
2019-03-05 16:23 ` [U-Boot] [PATCH v11 4/9] ARM: socfpga: Move the watchdog reset to the looping location tien.fong.chee at intel.com
2019-03-06 4:35 ` Dinh Nguyen
2019-03-07 8:04 ` Chee, Tien Fong
2019-03-05 16:23 ` [U-Boot] [PATCH v11 5/9] ARM: socfpga: Add FPGA drivers for Arria 10 FPGA bitstream loading tien.fong.chee at intel.com
2019-03-05 16:23 ` [U-Boot] [PATCH v11 6/9] ARM: socfpga: Add the configuration for FPGA SoCFPGA A10 SoCDK tien.fong.chee at intel.com
2019-03-06 4:11 ` Dinh Nguyen
2019-03-07 8:06 ` Chee, Tien Fong
2019-03-05 16:23 ` [U-Boot] [PATCH v11 7/9] spl : socfpga: Implement fpga bitstream loading with socfpga loadfs tien.fong.chee at intel.com
2019-03-05 16:23 ` [U-Boot] [PATCH v11 8/9] ARM: socfpga: Synchronize the configuration for A10 SoCDK tien.fong.chee at intel.com
2019-03-06 4:54 ` Dinh Nguyen
2019-03-07 8:14 ` Chee, Tien Fong
2019-03-05 16:23 ` [U-Boot] [PATCH v11 9/9] ARM: socfpga: Increase Malloc pool size to support FAT filesystem in SPL tien.fong.chee at intel.com
2019-03-05 20:05 ` Simon Goldschmidt
2019-03-06 2:04 ` Chee, Tien Fong
2019-03-07 7:07 ` Chee, Tien Fong
2019-03-07 8:10 ` Simon Goldschmidt
2019-03-07 8:32 ` Chee, Tien Fong
2019-03-06 4:52 ` Dinh Nguyen
2019-03-07 8:24 ` Chee, Tien Fong
2019-03-07 15:33 ` Dinh Nguyen
2019-03-08 4:36 ` Chee, Tien Fong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551945437.9744.18.camel@intel.com \
--to=tien.fong.chee@intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox