public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ley Foon Tan <ley.foon.tan@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: dts: socfpga: Add missing altr, sysmgr-syscon for EMAC
Date: Wed, 13 Mar 2019 13:59:35 +0800	[thread overview]
Message-ID: <1552456775.5582.12.camel@intel.com> (raw)
In-Reply-To: <fed328a1-3419-d1bc-e4b4-593d1263fee5@denx.de>

On Wed, 2019-03-13 at 04:30 +0100, Marek Vasut wrote:
> On 3/13/19 4:03 AM, Ley Foon Tan wrote:
> > 
> > Syscon register is required in dts to select correct
> > PHY interface.
> > 
> > Fix error below:
> > 
> > Net:   Failed to get syscon: -2
> > 
> > Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> Is this fixed in mainline Linux too ?
Didn't see this in mainline Linux.

Dinh, do you aware of this? I see sysmgr-syscon error in EMAC in v4.20
kernel.

[    1.427994] socfpga-dwmac ff800000.ethernet: Could not read
reg_offset from sysmgr-syscon!
[    1.436241] socfpga-dwmac ff800000.ethernet: Unable to parse OF data
[    1.442646] socfpga-dwmac: probe of ff800000.ethernet failed with
error -22


Regards
Ley Foon
> 
> > 
> > ---
> >  arch/arm/dts/socfpga_stratix10.dtsi | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/arch/arm/dts/socfpga_stratix10.dtsi
> > b/arch/arm/dts/socfpga_stratix10.dtsi
> > index ccd3f32301..ee93725d64 100644
> > --- a/arch/arm/dts/socfpga_stratix10.dtsi
> > +++ b/arch/arm/dts/socfpga_stratix10.dtsi
> > @@ -95,6 +95,7 @@
> >  			mac-address = [00 00 00 00 00 00];
> >  			resets = <&rst EMAC0_RESET>, <&rst
> > EMAC0_OCP_RESET>;
> >  			reset-names = "stmmaceth";
> > +			altr,sysmgr-syscon = <&sysmgr 0x44 0>;
> >  			status = "disabled";
> >  		};
> >  
> > @@ -106,6 +107,7 @@
> >  			mac-address = [00 00 00 00 00 00];
> >  			resets = <&rst EMAC1_RESET>, <&rst
> > EMAC1_OCP_RESET>;
> >  			reset-names = "stmmaceth";
> > +			altr,sysmgr-syscon = <&sysmgr 0x48 0>;
> >  			status = "disabled";
> >  		};
> >  
> > @@ -117,6 +119,7 @@
> >  			mac-address = [00 00 00 00 00 00];
> >  			resets = <&rst EMAC2_RESET>, <&rst
> > EMAC2_OCP_RESET>;
> >  			reset-names = "stmmaceth";
> > +			altr,sysmgr-syscon = <&sysmgr 0x4c 0>;
> >  			status = "disabled";
> >  		};
> >  
> > 
> 

  reply	other threads:[~2019-03-13  5:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13  3:03 [U-Boot] [PATCH] ARM: dts: socfpga: Add missing altr, sysmgr-syscon for EMAC Ley Foon Tan
2019-03-13  3:30 ` Marek Vasut
2019-03-13  5:59   ` Ley Foon Tan [this message]
2019-03-13  9:13     ` Marek Vasut
2019-03-13 14:32     ` Dinh Nguyen
2019-03-13 11:52       ` Ley Foon Tan
2019-03-13 15:33       ` Dinh Nguyen
2019-03-13 11:54         ` Ley Foon Tan
2019-03-14  2:26           ` Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1552456775.5582.12.camel@intel.com \
    --to=ley.foon.tan@intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox