From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ley Foon Tan Date: Wed, 13 Mar 2019 13:59:35 +0800 Subject: [U-Boot] [PATCH] ARM: dts: socfpga: Add missing altr, sysmgr-syscon for EMAC In-Reply-To: References: <1552446215-17067-1-git-send-email-ley.foon.tan@intel.com> Message-ID: <1552456775.5582.12.camel@intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On Wed, 2019-03-13 at 04:30 +0100, Marek Vasut wrote: > On 3/13/19 4:03 AM, Ley Foon Tan wrote: > > > > Syscon register is required in dts to select correct > > PHY interface. > > > > Fix error below: > > > > Net:   Failed to get syscon: -2 > > > > Signed-off-by: Ley Foon Tan > Is this fixed in mainline Linux too ? Didn't see this in mainline Linux. Dinh, do you aware of this? I see sysmgr-syscon error in EMAC in v4.20 kernel. [    1.427994] socfpga-dwmac ff800000.ethernet: Could not read reg_offset from sysmgr-syscon! [    1.436241] socfpga-dwmac ff800000.ethernet: Unable to parse OF data [    1.442646] socfpga-dwmac: probe of ff800000.ethernet failed with error -22 Regards Ley Foon > > > > > --- > >  arch/arm/dts/socfpga_stratix10.dtsi | 3 +++ > >  1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm/dts/socfpga_stratix10.dtsi > > b/arch/arm/dts/socfpga_stratix10.dtsi > > index ccd3f32301..ee93725d64 100644 > > --- a/arch/arm/dts/socfpga_stratix10.dtsi > > +++ b/arch/arm/dts/socfpga_stratix10.dtsi > > @@ -95,6 +95,7 @@ > >   mac-address = [00 00 00 00 00 00]; > >   resets = <&rst EMAC0_RESET>, <&rst > > EMAC0_OCP_RESET>; > >   reset-names = "stmmaceth"; > > + altr,sysmgr-syscon = <&sysmgr 0x44 0>; > >   status = "disabled"; > >   }; > >   > > @@ -106,6 +107,7 @@ > >   mac-address = [00 00 00 00 00 00]; > >   resets = <&rst EMAC1_RESET>, <&rst > > EMAC1_OCP_RESET>; > >   reset-names = "stmmaceth"; > > + altr,sysmgr-syscon = <&sysmgr 0x48 0>; > >   status = "disabled"; > >   }; > >   > > @@ -117,6 +119,7 @@ > >   mac-address = [00 00 00 00 00 00]; > >   resets = <&rst EMAC2_RESET>, <&rst > > EMAC2_OCP_RESET>; > >   reset-names = "stmmaceth"; > > + altr,sysmgr-syscon = <&sysmgr 0x4c 0>; > >   status = "disabled"; > >   }; > >   > > >