[U-Boot] [PATCH] ARM: dts: socfpga: Add missing altr, sysmgr-syscon for EMAC

Ley Foon Tan
2019-03-13T11:52:14Z

On Wed, 2019-03-13 at 09:32 -0500, Dinh Nguyen wrote:
>
> On 3/13/19 12:59 AM, Ley Foon Tan wrote:
> >
> > On Wed, 2019-03-13 at 04:30 +0100, Marek Vasut wrote:
> > >
> > > On 3/13/19 4:03 AM, Ley Foon Tan wrote:
> > > >
> > > >
> > > > Syscon register is required in dts to select correct
> > > > PHY interface.
> > > >
> > > > Fix error below:
> > > >
> > > > Net:   Failed to get syscon: -2
> > > >
> > > > Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> > > Is this fixed in mainline Linux too ?
> > Didn't see this in mainline Linux.
> >
> > Dinh, do you aware of this? I see sysmgr-syscon error in EMAC in
> > v4.20
> > kernel.
> >
> > [    1.427994] socfpga-dwmac ff800000.ethernet: Could not read
> > reg_offset from sysmgr-syscon!
> > [    1.436241] socfpga-dwmac ff800000.ethernet: Unable to parse OF
> > data
> > [    1.442646] socfpga-dwmac: probe of ff800000.ethernet failed
> > with
> > error -22
> >
> >
> I see this in mainline Linux:
>
> [    0.911521] socfpga-dwmac ff800000.ethernet: PTP uses main clock
> [    0.917530] socfpga-dwmac ff800000.ethernet: No sysmgr-syscon node
> found
> [    0.924209] socfpga-dwmac ff800000.ethernet: Unable to parse OF
> data
> [    0.930944] stmmaceth ff800000.ethernet: PTP uses main clock
> [    0.936723] stmmaceth ff800000.ethernet: User ID: 0x11, Synopsys
> ID: 0x37
> [    0.943496] stmmaceth ff800000.ethernet:     DWMAC1000
>
>
> It doesn't fail probing though. I'll look into it.
>
> Dinh
Why it probes driver twice? One with "socfpga-dwmac", another with
"stmmaceth".

There is error "No sysmgr-syscon node found". So, should we add
"sysmgr-syscon" dts parameter to dts?

Regards
Ley Foon