From: Chee, Tien Fong <tien.fong.chee@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] misc: fs_loader: Replace label with DT phandle
Date: Tue, 19 Mar 2019 08:55:20 +0000 [thread overview]
Message-ID: <1552985720.9784.0.camel@intel.com> (raw)
In-Reply-To: <CAPnjgZ1j06hyGM0NBqjX2_ru6Bh=Q7tWwiKaqMr=5c3+2wX=Qg@mail.gmail.com>
On Tue, 2019-03-19 at 09:22 +0800, Simon Glass wrote:
> Hi Tien Fong,
>
> On Mon, 11 Mar 2019 at 12:28, Chee, Tien Fong <tien.fong.chee@intel.c
> om> wrote:
> >
> >
> > On Sun, 2019-03-10 at 15:51 -0600, Simon Glass wrote:
> > >
> > > Hi Tien Fong,
> > >
> > > On Tue, 26 Feb 2019 at 05:37, Chee, Tien Fong <tien.fong.chee@int
> > > el.c
> > > om> wrote:
> > > >
> > > >
> > > >
> > > > On Fri, 2019-02-15 at 14:35 +0800, tien.fong.chee at intel.com
> > > > wrote:
> > > > >
> > > > >
> > > > > From: Tien Fong Chee <tien.fong.chee@intel.com>
> > > > >
> > > > > In previously label which will be expanded to the node's full
> > > > > path
> > > > > was
> > > > > used, and now replacing label with most commonly used DT
> > > > > phandle.
> > > > > The
> > > > > codes were changed accordingly to the use of DT phandle and
> > > > > supporting
> > > > > multiple instances.
> > > > >
> > > > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > > > > ---
> > > > > doc/driver-model/fs_firmware_loader.txt | 58
> > > > > +++++++++++++++++++++++++------
> > > > > drivers/misc/fs_loader.c | 36 ++++++++-----
> > > > > ----
> > > > > --
> > > > > 2 files changed, 62 insertions(+), 32 deletions(-)
> > > This seems OK to me, but I think this feature needs a test.
> > Yes, i have ran the test passed with FPGA driver.
> No I mean that you should add a test in test/py/tests
Okay, noted.
>
> Regards,
> Simon
prev parent reply other threads:[~2019-03-19 8:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 6:35 [U-Boot] [PATCH] misc: fs_loader: Replace label with DT phandle tien.fong.chee at intel.com
2019-02-26 12:37 ` Chee, Tien Fong
2019-03-10 21:51 ` Simon Glass
2019-03-11 4:28 ` Chee, Tien Fong
2019-03-19 1:22 ` Simon Glass
2019-03-19 8:55 ` Chee, Tien Fong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1552985720.9784.0.camel@intel.com \
--to=tien.fong.chee@intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox