From: Trent Piepho <tpiepho@impinj.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot,V4,1/2] mmc: add HS400 support
Date: Wed, 27 Mar 2019 20:43:04 +0000 [thread overview]
Message-ID: <1553719383.7410.53.camel@impinj.com> (raw)
In-Reply-To: <20180810060755.25287-1-peng.fan@nxp.com>
I didn't see HS400 working on my IMX7d, even thought it appears it
should be supported.
The problem appears to be when this bit of code in fsl_esdhc.c, which
dates to a patch "mmc: fsl_esdhc: support SDR104 and HS200":
static struct esdhc_soc_data usdhc_imx7d_data = {
.flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING
| ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200
| ESDHC_FLAG_HS400,
.caps = UHS_CAPS | MMC_MODE_HS200 | MMC_MODE_DDR_52MHz |
MMC_MODE_HS_52MHz | MMC_MODE_HS,
};
Notice that MMC_MODE_HS400 isn't in the caps list. Once I add that
uboot will attempt HS400 and it appears to work correctly.
I think maybe this patch should have added this to the caps?
Alternatively, there is a property that can be added to the device
tree, mmc-hs400-1_8v, that will add this cap. But the code to parse
those dt properties, mmc_of_parse(), isn't used by the fsl_esdhc
driver, which has its own parsing code that doesn't know about mmc-
hs400-1_8v.
So maybe fsl-esdhc should use mmc_of_parse() and the appropriate iMX
DTs should add those properties?
I think the DT method might be better, since it would allow the DT to
not list a mode that doesn't work due to the the board. I.e., the iMX
host supports the mode, the eMMC supports the mode, but the board
layout doesn't have traces that can support it. Too long, not matched
well enough, etc. It doesn't seem like there's an nice way to remove a
mode otherwise.
next prev parent reply other threads:[~2019-03-27 20:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 6:07 [U-Boot] [PATCH V4 1/2] mmc: add HS400 support Peng Fan
2018-08-10 6:07 ` [U-Boot] [PATCH V4 2/2] mmc: fsl_esdhc: enable HS400 feature Peng Fan
2018-09-11 12:25 ` [U-Boot] [U-Boot,V4,2/2] " Tom Rini
2018-08-29 5:32 ` [U-Boot] [PATCH V4 1/2] mmc: add HS400 support Peng Fan
2018-08-29 10:35 ` Marek Vasut
2018-08-29 11:21 ` Tom Rini
2018-09-11 12:25 ` [U-Boot] [U-Boot,V4,1/2] " Tom Rini
2019-03-27 20:43 ` Trent Piepho [this message]
2019-03-28 2:42 ` Marek Vasut
2019-03-29 18:12 ` Trent Piepho
2019-03-28 8:00 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553719383.7410.53.camel@impinj.com \
--to=tpiepho@impinj.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox