public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Trent Piepho <tpiepho@impinj.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot,V4,1/2] mmc: add HS400 support
Date: Fri, 29 Mar 2019 18:12:17 +0000	[thread overview]
Message-ID: <1553883136.7410.63.camel@impinj.com> (raw)
In-Reply-To: <45ddaa04-2cce-2489-d0b7-f3d1024ca572@denx.de>

On Thu, 2019-03-28 at 03:42 +0100, Marek Vasut wrote:
> On 3/27/19 9:43 PM, Trent Piepho wrote:
> > I didn't see HS400 working on my IMX7d, even thought it appears it
> > should be supported.
> > 
> > Alternatively, there is a property that can be added to the device
> > tree, mmc-hs400-1_8v, that will add this cap.  But the code to parse
> > those dt properties, mmc_of_parse(), isn't used by the fsl_esdhc
> > driver, which has its own parsing code that doesn't know about mmc-
> > hs400-1_8v.
> > 

> Right, please submit a patch switching over to the generic parsing code.
> Thanks
> 

So I looked into it a bit more, and while using the generic parsing
code seems like a good idea, there is still an issue.  None of the
kernel dts files for imx use any of the those properties to indicate
support.  The kernel driver has a built-in list of supported modes for
each device type and uses that.

So maybe consistency with the kernel is more important and the table of
OF device names to capabilities in u-boot should just be updated to
match what the kernel does.

But use the generic parsing code too.  I think I can add a property to
the generic that is described as a standard in the kernel mmc binding
and leave in just the imx some properties that are fsl specific.

  reply	other threads:[~2019-03-29 18:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-10  6:07 [U-Boot] [PATCH V4 1/2] mmc: add HS400 support Peng Fan
2018-08-10  6:07 ` [U-Boot] [PATCH V4 2/2] mmc: fsl_esdhc: enable HS400 feature Peng Fan
2018-09-11 12:25   ` [U-Boot] [U-Boot,V4,2/2] " Tom Rini
2018-08-29  5:32 ` [U-Boot] [PATCH V4 1/2] mmc: add HS400 support Peng Fan
2018-08-29 10:35   ` Marek Vasut
2018-08-29 11:21     ` Tom Rini
2018-09-11 12:25 ` [U-Boot] [U-Boot,V4,1/2] " Tom Rini
2019-03-27 20:43 ` Trent Piepho
2019-03-28  2:42   ` Marek Vasut
2019-03-29 18:12     ` Trent Piepho [this message]
2019-03-28  8:00   ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1553883136.7410.63.camel@impinj.com \
    --to=tpiepho@impinj.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox