From: Trent Piepho <tpiepho@impinj.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] i2c: mxc_i2c: Fix read and read->write xfers in DM mode
Date: Tue, 30 Apr 2019 16:04:32 +0000 [thread overview]
Message-ID: <1556640271.31309.11.camel@impinj.com> (raw)
In-Reply-To: <f20515c2-3713-f8bb-c87c-5c65a407ecf2@denx.de>
On Tue, 2019-04-30 at 06:34 +0200, Heiko Schocher wrote:
> Hello Trent,
>
> Am 16.04.2019 um 00:02 schrieb Trent Piepho:
> > This is an old driver that supports both device mapped and non-mapped
> > mode, and covers a wide range of hardware. It's hard to change without
> > risking breaking something. I have to tried to be exceedingly detailed
> > in this patch, so please excuse the length of the commit essay that
> > follows.
> >
> Thanks for this work!
>
> Your patch has
>
> total: 64 errors, 2 warnings, 0 checks, 145 lines checked
>
> Please fix and send a v2.
>
> It would be good to become here some Tested by tags ...
>
> Reviewed-by: Heiko Schocher <hs@denx.de>
My patches are fine before I send them. They are getting DOS line
endings added in transit. It seems Microsoft has recently changed
their mail server used for office365 to automatically add DOS line
endings to all text emails. It didn't use to do this. It seems the
only way to avoid this is to use base64 encoding with git send-email.
It works went I send a test message to myself and export from
Evolution. No way to test if the list software can handle it without
re-sending.
The patches should be automatically fixed by git am, as it will strip
DOS endings by default.
next prev parent reply other threads:[~2019-04-30 16:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 22:02 [U-Boot] [PATCH 1/2] i2c: mxc_i2c: Document how non-DM functions work Trent Piepho
2019-04-15 22:02 ` [U-Boot] [PATCH 2/2] i2c: mxc_i2c: Fix read and read->write xfers in DM mode Trent Piepho
2019-04-30 4:34 ` Heiko Schocher
2019-04-30 16:04 ` Trent Piepho [this message]
2019-05-02 5:23 ` Heiko Schocher
2019-05-03 21:19 ` Trent Piepho
2019-04-30 4:29 ` [U-Boot] [PATCH 1/2] i2c: mxc_i2c: Document how non-DM functions work Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556640271.31309.11.camel@impinj.com \
--to=tpiepho@impinj.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox