public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ang, Chee Hong <chee.hong.ang@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1] ARM: socfpga: stratix10: Enable DMA330 DMA controller
Date: Fri, 3 May 2019 15:53:07 +0000	[thread overview]
Message-ID: <1556898786.18578.5.camel@intel.com> (raw)
In-Reply-To: <7e3dd941-34f6-2dbf-c4bf-810c8955d8b3@denx.de>

On Fri, 2019-05-03 at 11:55 +0200, Marek Vasut wrote:
> On 5/3/19 10:18 AM, chee.hong.ang at intel.com wrote:
> > 
> > From: "Ang, Chee Hong" <chee.hong.ang@intel.com>
> Commit message is missing -- why do you need to enable the DMA330 ?
> 
> Don't you have a reset driver, like A10 and Gen5 ?
DMA driver for S10 is still missing in u-boot. I need to enable this
for booting Linux which is required by Linux's DMA driver.
I will add the reason to enable DMA330 in the commit message.
> 
> > 
> > Signed-off-by: Ang, Chee Hong <chee.hong.ang@intel.com>
> > ---
> >  arch/arm/mach-socfpga/include/mach/reset_manager_s10.h | 1 +
> >  arch/arm/mach-socfpga/spl_s10.c                        | 4 ++++
> >  2 files changed, 5 insertions(+)
> > 
> > diff --git a/arch/arm/mach-socfpga/include/mach/reset_manager_s10.h 
> > b/arch/arm/mach-socfpga/include/mach/reset_manager_s10.h
> > index e186296..3ac46c3 100644
> > --- a/arch/arm/mach-socfpga/include/mach/reset_manager_s10.h
> > +++ b/arch/arm/mach-socfpga/include/mach/reset_manager_s10.h
> > @@ -95,6 +95,7 @@ struct socfpga_reset_manager {
> >  #define RSTMGR_DMA		RSTMGR_DEFINE(1, 16)
> >  #define RSTMGR_SPIM0		RSTMGR_DEFINE(1, 17)
> >  #define RSTMGR_SPIM1		RSTMGR_DEFINE(1, 18)
> > +#define RSTMGR_DMA_OCP		RSTMGR_DEFINE(1, 21)
> >  #define RSTMGR_L4WD0		RSTMGR_DEFINE(2, 0)
> >  #define RSTMGR_L4WD1		RSTMGR_DEFINE(2, 1)
> >  #define RSTMGR_L4WD2		RSTMGR_DEFINE(2, 2)
> > diff --git a/arch/arm/mach-socfpga/spl_s10.c b/arch/arm/mach-
> > socfpga/spl_s10.c
> > index a141ffe..e063229 100644
> > --- a/arch/arm/mach-socfpga/spl_s10.c
> > +++ b/arch/arm/mach-socfpga/spl_s10.c
> > @@ -158,6 +158,10 @@ void board_init_f(ulong dummy)
> >  	writel(SYSMGR_DMA_IRQ_NS | SYSMGR_DMA_MGR_NS,
> > &sysmgr_regs->dma);
> >  	writel(SYSMGR_DMAPERIPH_ALL_NS, &sysmgr_regs->dma_periph);
> >  
> > +	/* enable DMA330 DMA */
> > +	socfpga_per_reset(SOCFPGA_RESET(DMA), 0);
> > +	socfpga_per_reset(SOCFPGA_RESET(DMA_OCP), 0);
> > +
> >  	spl_disable_firewall_l4_per();
> >  
> >  	spl_disable_firewall_l4_sys();
> > 
> 

  reply	other threads:[~2019-05-03 15:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-03  8:18 [U-Boot] [PATCH v1] ARM: socfpga: stratix10: Enable DMA330 DMA controller chee.hong.ang at intel.com
2019-05-03  9:55 ` Marek Vasut
2019-05-03 15:53   ` Ang, Chee Hong [this message]
2019-05-03 17:04     ` Marek Vasut
2019-05-03 17:56       ` Ang, Chee Hong
2019-05-03 19:31         ` Marek Vasut
2019-05-07  3:28           ` Ang, Chee Hong
2019-05-07  3:39             ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1556898786.18578.5.camel@intel.com \
    --to=chee.hong.ang@intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox