From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99165C433F5 for ; Fri, 22 Apr 2022 12:07:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8688483D6E; Fri, 22 Apr 2022 14:07:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kfK69X8S"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0455083D71; Fri, 22 Apr 2022 14:07:14 +0200 (CEST) Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2B69383D6D for ; Fri, 22 Apr 2022 14:07:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@gmail.com Received: by mail-pl1-x62e.google.com with SMTP id b7so10404227plh.2 for ; Fri, 22 Apr 2022 05:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=DNVLvDG1PnKiIf2GEToROuhy7dLYZ+B5rf3PMV26kfg=; b=kfK69X8S6KrQYZ4Sjgd3CDxhTfMTOxpThFPZjenZmZ6rClWnvgTXhh7xzkqpTXMhoz owffdDNjXga4FsPMJPurSJaAw1KrdtHE9RF+o8YbX9npNCCtW+pNuRBZtlJZO3Na1OTL XgqI5CkO0a8In3axYr3eBkA8rw3xcaRqkcUnKVRg7fldKXr9oimnZjMugz4PGqTO17mi cC79zAE8r3BT3NkWMfdZ8IxRKQSgJ/Iz5g9s+uJexmXgwFiuAQyEXA8yujPeiqO11Cj3 M6HFpOhldUfjWEcdX66bjm/0Yeit1j/lQE59K7DiECAR5BZn8Wxbc6b7v7cilOFVzYtX /kZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=DNVLvDG1PnKiIf2GEToROuhy7dLYZ+B5rf3PMV26kfg=; b=0VxTqOGvq4DIqOspM8jBPU5x9Nb4uaN5DpxRnEGLXOFMSPvesIs9Qyh6rK6OtTZl3s mKVNc3GTT+41DO020MuNNsRgdmo6chtJSyYkvr2coRchFVqQsQ2tX8ctOOstU7ZH5vtc bMhp4qLrlxMhPvEmZvXJUldMmOPTtWRWPgb/TW9E5OzciNAWTGT8Su7HoyR382ARRi1U LoY9PBr7CMsX1qeN6uHvC0ggNlvu1FjMkY6zuiIeIeGI68LNa+vZ+grv4VT1TkXYquJ+ 5llVas0ac1i+hUPeUS+fmYuWuqd9xPbt8ggHHTm5JgGO9+9jWYd+wPJLR1ppUU5KYYdc +0vA== X-Gm-Message-State: AOAM531ChcUVl63vfDZzpQQKa6Ty5op6uIZXJXvwcF+F3NRJPYtoWatz NFd+onomUxftHkI2TEDa/VM= X-Google-Smtp-Source: ABdhPJxhPtNGZYZ5pSM3eEacfwexpByktb3Mi51ucpVHjjlLZVblkU1Sc1zxiBCDo1kDAVdLq/r74w== X-Received: by 2002:a17:902:eb83:b0:15c:a25:7db2 with SMTP id q3-20020a170902eb8300b0015c0a257db2mr2732120plg.161.1650629228982; Fri, 22 Apr 2022 05:07:08 -0700 (PDT) Received: from [192.168.0.19] ([183.99.112.216]) by smtp.gmail.com with ESMTPSA id ck14-20020a056a00328e00b0050a3c5f415csm2333868pfb.23.2022.04.22.05.07.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Apr 2022 05:07:07 -0700 (PDT) Message-ID: <15592a6b-d2f6-8d01-62fc-261a46fc1817@gmail.com> Date: Fri, 22 Apr 2022 21:07:05 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 2/3] mmc: fsl_esdhc_spl: pre-PBL: fix determining U-Boot size Content-Language: en-US To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Priyanka Jain , Peng Fan , Jaehoon Chung Cc: u-boot@lists.denx.de References: <20220402221701.18498-1-pali@kernel.org> <20220402221701.18498-3-pali@kernel.org> From: Jaehoon Chung In-Reply-To: <20220402221701.18498-3-pali@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 4/3/22 07:17, Pali Rohár wrote: > In pre-PBL header is stored size of code which BootROM copies from SD card > to L2/SRAM. This size has upper limit of L2 cache size. In most cases this > is size of U-Boot SPL or size of L2 cache. > > Therefore this size in pre-PBL header cannot be used for determining size > of proper U-Boot. > > So always use CONFIG_SYS_MMC_U_BOOT_SIZE for determining size of proper > U-Boot which stored on SD card. > > Signed-off-by: Pali Rohár Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/mmc/fsl_esdhc_spl.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/mmc/fsl_esdhc_spl.c b/drivers/mmc/fsl_esdhc_spl.c > index 109f558dcad3..b87597a88e1d 100644 > --- a/drivers/mmc/fsl_esdhc_spl.c > +++ b/drivers/mmc/fsl_esdhc_spl.c > @@ -79,7 +79,6 @@ void __noreturn mmc_boot(void) > > #ifdef CONFIG_FSL_CORENET > offset = CONFIG_SYS_MMC_U_BOOT_OFFS; > - code_len = CONFIG_SYS_MMC_U_BOOT_SIZE; > #else > blklen = mmc->read_bl_len; > tmp_buf = malloc(blklen); > @@ -135,18 +134,11 @@ void __noreturn mmc_boot(void) > offset = (offset << 8) + val; > } > offset += CONFIG_SYS_MMC_U_BOOT_OFFS; > - /* Get the code size from offset 0x48 */ > - byte_num = 4; > - code_len = 0; > - for (i = 0; i < byte_num; i++) { > - val = *(tmp_buf + ESDHC_BOOT_IMAGE_SIZE + i); > - code_len = (code_len << 8) + val; > - } > - code_len -= CONFIG_SYS_MMC_U_BOOT_OFFS; > +#endif > /* > * Load U-Boot image from mmc into RAM > */ > -#endif > + code_len = CONFIG_SYS_MMC_U_BOOT_SIZE; > blk_start = ALIGN(offset, mmc->read_bl_len) / mmc->read_bl_len; > blk_cnt = ALIGN(code_len, mmc->read_bl_len) / mmc->read_bl_len; > err = mmc->block_dev.block_read(&mmc->block_dev, blk_start, blk_cnt,