From: Pavel Herrmann <morpheus.ibis@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix checkpatch warnings about externs in *.c
Date: Sun, 16 Sep 2012 14:59:45 +0200 [thread overview]
Message-ID: <1562773.QJqAFDZTY0@merom> (raw)
In-Reply-To: <201209161437.16532.marex@denx.de>
On Sunday 16 September 2012 14:37:16 Marek Vasut wrote:
> Dear Pavel Herrmann,
> ...
> Won't include/sata.h work just fine ?
I feel include/sata.h is a "consumer-facing" header, and implementation
details such as the array used for all data-retention for command and drivers
should not be there.
Therefore i created a new header in drivers/block for this purpose, feel free
to oppose to its name though.
Pavel Herrmann
next prev parent reply other threads:[~2012-09-16 12:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-16 11:53 [U-Boot] [PATCH] Fix checkpatch warnings about externs in *.c Pavel Herrmann
2012-09-16 12:37 ` Marek Vasut
2012-09-16 12:59 ` Pavel Herrmann [this message]
2012-09-16 13:11 ` Marek Vasut
2012-09-17 19:05 ` Tom Rini
2012-09-28 9:18 ` [U-Boot] [PATCH 1/2] remove unnecessary code in ata_piix Pavel Herrmann
2012-09-28 9:18 ` [U-Boot] [PATCH v2 2/2] Fix checkpatch warnings about externs in *.c Pavel Herrmann
2012-09-28 18:13 ` Marek Vasut
2012-09-28 19:39 ` Tom Rini
2012-09-28 18:12 ` [U-Boot] [PATCH 1/2] remove unnecessary code in ata_piix Marek Vasut
2012-09-28 18:29 ` Tom Rini
2012-09-29 14:52 ` [U-Boot] [U-Boot,1/2] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1562773.QJqAFDZTY0@merom \
--to=morpheus.ibis@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox