From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Herrmann Date: Sun, 16 Sep 2012 14:59:45 +0200 Subject: [U-Boot] [PATCH] Fix checkpatch warnings about externs in *.c In-Reply-To: <201209161437.16532.marex@denx.de> References: <1347796413-15515-1-git-send-email-morpheus.ibis@gmail.com> <201209161437.16532.marex@denx.de> Message-ID: <1562773.QJqAFDZTY0@merom> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sunday 16 September 2012 14:37:16 Marek Vasut wrote: > Dear Pavel Herrmann, > ... > Won't include/sata.h work just fine ? I feel include/sata.h is a "consumer-facing" header, and implementation details such as the array used for all data-retention for command and drivers should not be there. Therefore i created a new header in drivers/block for this purpose, feel free to oppose to its name though. Pavel Herrmann