From: Weijie Gao <weijie.gao@mediatek.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 26/26] configs: mtmips: add necessary drivers for mtmips boards
Date: Thu, 29 Aug 2019 11:34:33 +0800 [thread overview]
Message-ID: <1567049673.2874.124.camel@mcddlt001> (raw)
In-Reply-To: <6b53da4e-e0f1-b3ad-6628-8dcfdb8a055e@denx.de>
On Wed, 2019-08-28 at 15:40 +0200, Stefan Roese wrote:
> On 28.08.19 15:35, Daniel Schwierzeck wrote:
> >
> >
> > Am 28.08.19 um 08:38 schrieb Weijie Gao:
> >> This patch adds pinctrl driver, clock gate driver and reset controller
> >> support for defconfig files of mtmips boards.
> >>
> >> Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>
> >> ---
> >> configs/gardena-smart-gateway-mt7688_defconfig | 6 ++++++
> >> configs/linkit-smart-7688_defconfig | 6 ++++++
> >> 2 files changed, 12 insertions(+)
> >>
> >> diff --git a/configs/gardena-smart-gateway-mt7688_defconfig b/configs/gardena-smart-gateway-mt7688_defconfig
> >> index 1e270cb61d..83e793042a 100644
> >> --- a/configs/gardena-smart-gateway-mt7688_defconfig
> >> +++ b/configs/gardena-smart-gateway-mt7688_defconfig
> >> @@ -49,6 +49,7 @@ CONFIG_NET_RANDOM_ETHADDR=y
> >> CONFIG_HAVE_BLOCK_DEVICE=y
> >> CONFIG_BOOTCOUNT_LIMIT=y
> >> CONFIG_CLK=y
> >> +CONFIG_CLK_MTMIPS_GATE=y
> >> CONFIG_LED=y
> >> CONFIG_LED_BLINK=y
> >> CONFIG_LED_GPIO=y
> >> @@ -67,10 +68,15 @@ CONFIG_PHYLIB=y
> >> CONFIG_PHY_FIXED=y
> >> CONFIG_MT7628_ETH=y
> >> CONFIG_PHY=y
> >> +CONFIG_PINCTRL=y
> >> +CONFIG_PINMUX=y
> >> +CONFIG_PINCONF=y
> >> +CONFIG_PINCTRL_MT7628=y
> >> CONFIG_POWER_DOMAIN=y
> >> CONFIG_RAM=y
> >> CONFIG_DM_RESET=y
> >> # CONFIG_SPL_SERIAL_PRESENT is not set
> >> +CONFIG_RESET_MTMIPS=y
> >
> > if the SoC only works with those drivers enabled, you should consider to
> > select all according Kconfig symbols in arch/mips/mach-mtmips/Kconfig so
> > an user can't configure a non-working board config by mistake.
>
> I agree. Please move those selections to Kconfig (select XXX).
>
> And please re-think about using the generic drivers for pinctrl and clock
> (as also remarked by Daniel).
>
> Thanks,
> Stefan
>
> >
> >> CONFIG_MTK_SERIAL=y
> >> CONFIG_SPI=y
> >> CONFIG_MT7621_SPI=y
> >> diff --git a/configs/linkit-smart-7688_defconfig b/configs/linkit-smart-7688_defconfig
> >> index 743cc48166..13f5cf8a21 100644
> >> --- a/configs/linkit-smart-7688_defconfig
> >> +++ b/configs/linkit-smart-7688_defconfig
> >> @@ -40,6 +40,7 @@ CONFIG_NET_RANDOM_ETHADDR=y
> >> # CONFIG_DM_DEVICE_REMOVE is not set
> >> CONFIG_BLK=y
> >> CONFIG_CLK=y
> >> +CONFIG_CLK_MTMIPS_GATE=y
> >> CONFIG_LED=y
> >> CONFIG_LED_BLINK=y
> >> CONFIG_LED_GPIO=y
> >> @@ -55,10 +56,15 @@ CONFIG_PHY_FIXED=y
> >> CONFIG_MT7628_ETH=y
> >> CONFIG_PHY=y
> >> CONFIG_MT76X8_USB_PHY=y
> >> +CONFIG_PINCTRL=y
> >> +CONFIG_PINMUX=y
> >> +CONFIG_PINCONF=y
> >> +CONFIG_PINCTRL_MT7628=y
> >> CONFIG_POWER_DOMAIN=y
> >> CONFIG_RAM=y
> >> CONFIG_DM_RESET=y
> >> # CONFIG_SPL_SERIAL_PRESENT is not set
> >> +CONFIG_RESET_MTMIPS=y
> >> CONFIG_MTK_SERIAL=y
> >> CONFIG_SPI=y
> >> CONFIG_MT7621_SPI=y
> >>
> >
>
> Viele Grüße,
> Stefan
>
I'll move them to mach-mtmips/Kconfig.
prev parent reply other threads:[~2019-08-29 3:34 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 6:37 [U-Boot] [PATCH 00/26] Add and update drivers for MediaTek MT76x8 SoCs Weijie Gao
2019-08-28 6:37 ` [U-Boot] [PATCH 01/26] serial: serial_mtk: enable FIFO and disable flow control Weijie Gao
2019-08-28 6:37 ` [U-Boot] [PATCH 02/26] serial: serial_mtk: add non-DM version for SPL Weijie Gao
2019-08-28 6:37 ` [U-Boot] [PATCH 03/26] dts: mtmips: move uart property clock-frequency into mt7628an.dtsi Weijie Gao
2019-08-28 7:13 ` Stefan Roese
2019-08-28 6:37 ` [U-Boot] [PATCH 04/26] dts: mtmips: enable high-speed UART support for mt7628 Weijie Gao
2019-08-28 7:14 ` Stefan Roese
2019-08-28 6:37 ` [U-Boot] [PATCH 05/26] spi: mt7621-spi: remove data cache and rewrite its xfer function Weijie Gao
2019-08-28 7:55 ` Stefan Roese
2019-08-28 6:37 ` [U-Boot] [PATCH 06/26] spi: mt7621-spi: restore default register value after each xfer Weijie Gao
2019-08-28 8:01 ` Stefan Roese
2019-08-28 6:37 ` [U-Boot] [PATCH 07/26] pinctrl: add support for MediaTek MT7628 Weijie Gao
2019-08-28 12:26 ` Stefan Roese
2019-08-28 12:37 ` Stefan Roese
2019-08-29 3:04 ` Weijie Gao
2019-08-28 6:37 ` [U-Boot] [PATCH 08/26] dts: mtmips: add pinctrl node for mt7628 Weijie Gao
2019-08-28 6:37 ` [U-Boot] [PATCH 09/26] dts: mtmips: add default pinctrl for uart nodes Weijie Gao
2019-08-28 6:37 ` [U-Boot] [PATCH 10/26] reset: add reset controller driver for MediaTek MIPS platform Weijie Gao
2019-08-28 6:37 ` [U-Boot] [PATCH 11/26] dts: mtmips: update reset controller node for mt7628 Weijie Gao
2019-08-28 13:18 ` Stefan Roese
2019-08-29 3:18 ` Weijie Gao
2019-12-30 9:19 ` Mauro Condarelli
2019-12-30 10:22 ` Daniel Schwierzeck
2019-12-30 11:09 ` Mauro Condarelli
2019-12-30 12:14 ` Mauro Condarelli
2020-01-02 12:30 ` Stefan Roese
2020-01-02 13:36 ` Mauro Condarelli
2019-08-28 6:37 ` [U-Boot] [PATCH 12/26] clk: add clock gating driver for MediaTek MIPS platform Weijie Gao
2019-08-28 13:24 ` Daniel Schwierzeck
2019-08-29 3:25 ` Weijie Gao
2019-08-28 6:37 ` [U-Boot] [PATCH 13/26] dts: mtmips: add gate clock node for mt7628 Weijie Gao
2019-08-28 6:37 ` [U-Boot] [PATCH 14/26] phy: mt76x8-usb-phy: add slew rate calibration and remove non-mt7628 part Weijie Gao
2019-08-28 6:38 ` [U-Boot] [PATCH 15/26] net: mt7628-eth: remove hardcoded gpio settings and regmap-based phy reset Weijie Gao
2019-08-28 13:32 ` Stefan Roese
2019-08-28 6:38 ` [U-Boot] [PATCH 16/26] net: mt7628-eth: remove phy link up detection Weijie Gao
2019-08-28 13:37 ` Stefan Roese
2019-08-29 3:32 ` Weijie Gao
2019-08-28 6:38 ` [U-Boot] [PATCH 17/26] net: mt7628-eth: free rx descriptor on receiving failure Weijie Gao
2019-08-28 13:42 ` Stefan Roese
2019-08-28 6:38 ` [U-Boot] [PATCH 18/26] net: mt7628-eth: add support to isolate LAN/WAN ports Weijie Gao
2019-08-28 13:46 ` Stefan Roese
2019-08-29 4:27 ` Weijie Gao
2019-08-28 6:38 ` [U-Boot] [PATCH 19/26] dts: mtmips: enable eth port0 led function for all boards Weijie Gao
2019-08-28 13:47 ` Stefan Roese
2019-08-28 6:38 ` [U-Boot] [PATCH 20/26] mmc: mtk-sd: add support for MediaTek MT7620/MT7628 SoCs Weijie Gao
2019-08-28 13:50 ` Stefan Roese
2019-08-29 4:28 ` Weijie Gao
2019-08-28 6:38 ` [U-Boot] [PATCH 21/26] mmc: mtk-sd: add a dts property cd-active-high for builtin-cd mode Weijie Gao
2019-08-28 6:38 ` [U-Boot] [PATCH 22/26] dts: mtmips: add mmc related nodes for mt7628an.dtsi Weijie Gao
2019-08-28 6:38 ` [U-Boot] [PATCH 23/26] dts: mtmips: add default pinctrl for gardena-smart-gateway-mt7688 Weijie Gao
2019-08-28 13:52 ` Stefan Roese
2019-08-28 6:38 ` [U-Boot] [PATCH 24/26] dts: mtmips: add default pinctrl to eth nodes for all boards Weijie Gao
2019-08-28 13:55 ` Stefan Roese
2019-08-28 6:38 ` [U-Boot] [PATCH 25/26] configs: mtmips: change all boards to use mtk high-speed uart driver Weijie Gao
2019-08-28 13:57 ` Stefan Roese
2019-08-29 4:30 ` Weijie Gao
2019-08-28 6:38 ` [U-Boot] [PATCH 26/26] configs: mtmips: add necessary drivers for mtmips boards Weijie Gao
2019-08-28 13:35 ` Daniel Schwierzeck
2019-08-28 13:40 ` Stefan Roese
2019-08-29 3:34 ` Weijie Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1567049673.2874.124.camel@mcddlt001 \
--to=weijie.gao@mediatek.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox