From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/5] README: The ver env var is not read-only
Date: Sun, 12 Aug 2012 15:58:24 +0200 (CEST) [thread overview]
Message-ID: <1570485258.2324100.1344779904049.JavaMail.root@advansee.com> (raw)
In-Reply-To: <20120812115457.4B385202A85@gemini.denx.de>
Dear Wolfgang Denk,
> > I had thought about that, but there is an issue. main_loop() sets
> > this env var,
> > so if ver is made read-only and the env is stored somewhere (NVRAM,
> > etc.), then
> > after an update of U-Boot with a newer version (stored env
> > untouched), ver will
> > still indicate the older version. See commit 155cb01, which forgot
> > to update the
>
> No. main_loop() will always set this variable to the right value, no
> matter what might be stored in the environment. Only if you then
> change i later you may (temporarily) see a different value. But
> again
> only until you reset the board.
Yes, I agree. The behavior that I described is what would occur _if_ commit
155cb01 were reverted in order to make ver truly read-only like Mike asked for.
The current behavior is not too bad for now.
> The correct fix for this would be the introduction of variable types,
> including flags like "read-only" (as for serial# or ethaddr) or
> "volatile" (i. e. not included in saveenv, as for filesize etc.)
>
> I have been thinking about this for a long time already, I just
> didn't
> find time yet to implement it.
OK. Don't you think that the README file should be updated in some way in the
meantime to reflect this, since ver is neither read-only nor "normal"?
Best regards,
Beno?t
next prev parent reply other threads:[~2012-08-12 13:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 17:44 [U-Boot] [PATCH 0/5] Cleanup and extend env vars Benoît Thébaudeau
2012-08-10 17:45 ` [U-Boot] [PATCH 1/5] fw_env: Add env vars describing U-Boot target board Benoît Thébaudeau
2012-09-18 19:04 ` [U-Boot] [U-Boot, " Tom Rini
2012-08-10 17:45 ` [U-Boot] [PATCH 2/5] env_common: Add missing ethprime Benoît Thébaudeau
2012-09-18 19:05 ` [U-Boot] [U-Boot,2/5] " Tom Rini
2012-08-10 17:45 ` [U-Boot] [PATCH 3/5] env import/export: Remove from help if disabled Benoît Thébaudeau
2012-08-11 17:48 ` Mike Frysinger
2012-09-18 19:05 ` [U-Boot] [U-Boot, " Tom Rini
2012-08-10 17:45 ` [U-Boot] [PATCH 4/5] README: The ver env var is not read-only Benoît Thébaudeau
2012-08-11 17:48 ` Mike Frysinger
2012-08-11 18:07 ` Benoît Thébaudeau
2012-08-12 11:54 ` Wolfgang Denk
2012-08-12 13:58 ` Benoît Thébaudeau [this message]
2012-08-12 14:49 ` Mike Frysinger
2012-08-13 13:01 ` [U-Boot] [PATCH] README: Update ver env var description Benoît Thébaudeau
2012-08-17 4:20 ` Mike Frysinger
2012-09-02 16:56 ` Wolfgang Denk
2012-08-12 11:49 ` [U-Boot] [PATCH 4/5] README: The ver env var is not read-only Wolfgang Denk
2012-08-10 17:46 ` [U-Boot] [PATCH 5/5] Add env var giving the board revision Benoît Thébaudeau
2012-08-11 17:48 ` Mike Frysinger
2012-08-11 19:11 ` Benoît Thébaudeau
2012-08-12 11:58 ` Wolfgang Denk
2012-08-12 14:02 ` Benoît Thébaudeau
2012-08-12 14:09 ` Benoît Thébaudeau
2012-08-12 21:06 ` Wolfgang Denk
2012-08-12 21:21 ` Jeroen Hofstee
2012-08-12 14:54 ` Mike Frysinger
2012-08-12 17:11 ` Benoît Thébaudeau
2012-08-12 21:20 ` Wolfgang Denk
2012-08-12 21:35 ` Benoît Thébaudeau
2012-08-13 9:59 ` Wolfgang Denk
2012-08-13 0:28 ` Mike Frysinger
2012-08-12 21:05 ` Wolfgang Denk
2012-08-12 11:51 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1570485258.2324100.1344779904049.JavaMail.root@advansee.com \
--to=benoit.thebaudeau@advansee.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox