public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mingming Lee <mingming.lee@mediatek.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5] ARM: MediaTek: Add support for MediaTek MT8518 SoC
Date: Tue, 15 Oct 2019 14:42:29 +0800	[thread overview]
Message-ID: <1571121749.16884.2.camel@mhfsdcap03> (raw)
In-Reply-To: <00ab76fb-8c76-1126-a929-c4145678f49c@gmail.com>

On Sun, 2019-10-13 at 18:55 +0800, Matthias Brugger wrote:
> 
> On 11/09/2019 13:14, mingming lee wrote:
> > Add support for MediaTek MT8518 SoC. This include the file
> > that will initialize the SoC after boot and its device tree.
> > 
> > Signed-off-by: mingming lee <mingming.lee@mediatek.com>
> > ---
> >  arch/arm/dts/mt8518.dtsi                      | 201 ++++++++++++++++++
> >  arch/arm/mach-mediatek/Kconfig                |   9 +
> >  arch/arm/mach-mediatek/Makefile               |   1 +
> >  arch/arm/mach-mediatek/mt8518/Makefile        |   4 +
> >  arch/arm/mach-mediatek/mt8518/init.c          | 116 ++++++++++
> >  arch/arm/mach-mediatek/mt8518/lowlevel_init.S |  59 +++++
> >  6 files changed, 390 insertions(+)
> >  create mode 100644 arch/arm/dts/mt8518.dtsi
> >  create mode 100644 arch/arm/mach-mediatek/mt8518/Makefile
> >  create mode 100644 arch/arm/mach-mediatek/mt8518/init.c
> >  create mode 100644 arch/arm/mach-mediatek/mt8518/lowlevel_init.S
> > 
> > diff --git a/arch/arm/dts/mt8518.dtsi b/arch/arm/dts/mt8518.dtsi
> > new file mode 100644
> > index 0000000000..39d001884f
> > --- /dev/null
> > +++ b/arch/arm/dts/mt8518.dtsi
> > @@ -0,0 +1,201 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > +/*
> > + * Copyright (C) 2019 MediaTek Inc.
> > + * Author: Mingming Lee <mingming.lee@mediatek.com>
> > + *
> > + */
> > +
> > +#include <dt-bindings/clock/mt8518-clk.h>
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/interrupt-controller/irq.h>
> > +#include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +/ {
> > +	compatible = "mediatek,mt8518";
> > +	interrupt-parent = <&sysirq>;
> > +	#address-cells = <1>;
> > +	#size-cells = <1>;
> > +
> > +	cpus {
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +		enable-method = "mediatek,mt8518-smp";
> > +
> > +		cpu0: cpu at 0 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a53";
> > +			reg = <0x0>;
> > +			clock-frequency = <1300000000>;
> > +		};
> > +
> > +		cpu1: cpu at 1 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a53";
> > +			reg = <0x1>;
> > +			clock-frequency = <1300000000>;
> > +		};
> > +
> > +		cpu2: cpu at 2 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a53";
> > +			reg = <0x2>;
> > +			clock-frequency = <1300000000>;
> > +		};
> > +
> > +		cpu3: cpu at 3 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a53";
> > +			reg = <0x3>;
> > +			clock-frequency = <1300000000>;
> > +		};
> > +	};
> > +
> > +	chipid: chipid at 08000000 {
> > +		compatible = "mediatek,chipid";
> > +		reg = <0x08000000 0x0004>,
> > +		      <0x08000004 0x0004>,
> > +		      <0x08000008 0x0004>,
> > +		      <0x0800000c 0x0004>;
> > +	};
> 
> I couldn't find any driver using this compatible.
> You may want to drop this 'device'.
> 
> Regards,
> Matthias

Thank you for review.
I will drop this 'device' and also drop other unused 'device'.

  parent reply	other threads:[~2019-10-15  6:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11 11:14 [U-Boot] [PATCH 0/5] Add support for MediaTek MT8518 Soc mingming lee
2019-09-11 11:14 ` [U-Boot] [PATCH 1/5] ARM: MediaTek: Add support for MediaTek MT8518 SoC mingming lee
2019-10-13 10:55   ` Matthias Brugger
2019-10-15  6:25     ` Mingming Lee
2019-10-15  6:42     ` Mingming Lee [this message]
2019-10-15  6:56     ` Mingming Lee
2019-09-11 11:14 ` [U-Boot] [PATCH 2/5] clk: mediatek: add driver for MT8518 mingming lee
2019-09-11 11:14 ` [U-Boot] [PATCH 3/5] mmc: mtk-sd: add HS200 support mingming lee
2019-09-11 11:14 ` [U-Boot] [PATCH 4/5] pinctrl: add driver for MT8518 mingming lee
2019-09-11 11:14 ` [U-Boot] [PATCH 5/5] ARM: MediaTek: add basic support for MT8518 boards mingming lee
2019-10-11 17:28   ` Tom Rini
2019-10-15  9:38     ` Mingming Lee
     [not found] <20190911064818.1723-1-mingming.lee@mediatek.com>
2019-09-11  6:48 ` [U-Boot] [PATCH 1/5] ARM: MediaTek: Add support for MediaTek MT8518 SoC mingming lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1571121749.16884.2.camel@mhfsdcap03 \
    --to=mingming.lee@mediatek.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox