* [U-Boot] [PATCH] ddr: socfpga: gen5: constify altera_gen5_sdram_ops
@ 2019-10-23 20:19 Simon Goldschmidt
2019-10-24 2:55 ` Ley Foon Tan
0 siblings, 1 reply; 2+ messages in thread
From: Simon Goldschmidt @ 2019-10-23 20:19 UTC (permalink / raw)
To: u-boot
Make the function pointer struct const, as it does not need to be
writable. This doesn't really change anything other than moving this
variable to a different section. No functional change.
Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
---
drivers/ddr/altera/sdram_gen5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ddr/altera/sdram_gen5.c b/drivers/ddr/altera/sdram_gen5.c
index fcd89b619d..8c8ea19eb9 100644
--- a/drivers/ddr/altera/sdram_gen5.c
+++ b/drivers/ddr/altera/sdram_gen5.c
@@ -626,7 +626,7 @@ static int altera_gen5_sdram_get_info(struct udevice *dev,
return 0;
}
-static struct ram_ops altera_gen5_sdram_ops = {
+static const struct ram_ops altera_gen5_sdram_ops = {
.get_info = altera_gen5_sdram_get_info,
};
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] ddr: socfpga: gen5: constify altera_gen5_sdram_ops
2019-10-23 20:19 [U-Boot] [PATCH] ddr: socfpga: gen5: constify altera_gen5_sdram_ops Simon Goldschmidt
@ 2019-10-24 2:55 ` Ley Foon Tan
0 siblings, 0 replies; 2+ messages in thread
From: Ley Foon Tan @ 2019-10-24 2:55 UTC (permalink / raw)
To: u-boot
On Wed, 2019-10-23 at 22:19 +0200, Simon Goldschmidt wrote:
> Make the function pointer struct const, as it does not need to be
> writable. This doesn't really change anything other than moving this
> variable to a different section. No functional change.
>
> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
Reviewed-by: Ley Foon Tan <ley.foon.tan@intel.com>
> ---
>
> drivers/ddr/altera/sdram_gen5.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ddr/altera/sdram_gen5.c
> b/drivers/ddr/altera/sdram_gen5.c
> index fcd89b619d..8c8ea19eb9 100644
> --- a/drivers/ddr/altera/sdram_gen5.c
> +++ b/drivers/ddr/altera/sdram_gen5.c
> @@ -626,7 +626,7 @@ static int altera_gen5_sdram_get_info(struct
> udevice *dev,
> return 0;
> }
>
> -static struct ram_ops altera_gen5_sdram_ops = {
> +static const struct ram_ops altera_gen5_sdram_ops = {
> .get_info = altera_gen5_sdram_get_info,
> };
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-24 2:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-23 20:19 [U-Boot] [PATCH] ddr: socfpga: gen5: constify altera_gen5_sdram_ops Simon Goldschmidt
2019-10-24 2:55 ` Ley Foon Tan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox