public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Weijie Gao <weijie.gao@mediatek.com>
To: u-boot@lists.denx.de
Subject: [PATCH 04/16] mips: add an option to support customized get_tbclk()
Date: Thu, 9 Jan 2020 16:30:22 +0800	[thread overview]
Message-ID: <1578558622.5535.13.camel@mcddlt001> (raw)
In-Reply-To: <75f88fb4-9fb7-659d-f12d-0ba8b23fddf4@gmail.com>

On Wed, 2020-01-08 at 15:32 +0100, Daniel Schwierzeck wrote:
> 
> Am 08.01.20 um 04:01 schrieb Weijie Gao:
> > Some systems boot up at a very low CPU frequency and set up a higher CPU
> > frequency in lowlevel initialization.
> > 
> > Currently get_tbclk() uses a fixed value (CONFIG_SYS_MIPS_TIMER_FREQ)
> > for MIPS architercture, and CONFIG_SYS_MIPS_TIMER_FREQ is usually related
> > to the higher CPU frequency. If udelay() is used before setting up CPU
> > frequency, it will be very inaccurate.
> > 
> > This patch adds an option to allow a mach to define its own get_tbclk().
> > 
> > Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>
> > ---
> >  arch/mips/Kconfig    | 8 ++++++++
> >  arch/mips/cpu/time.c | 2 ++
> >  2 files changed, 10 insertions(+)
> > 
> > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > index 4688717593..52afbf79c5 100644
> > --- a/arch/mips/Kconfig
> > +++ b/arch/mips/Kconfig
> > @@ -502,6 +502,14 @@ config MIPS_BOOT_CONFIG_WORD1
> >  	help
> >  	  Value which is inserted as boot config word 1.
> >  
> > +config MIPS_OVERRIDE_GET_TBCLK
> > +	bool
> > +	default n
> > +	help
> > +	  Select this if you want to override the default get_tbclk() for your
> > +	  system. This usually means the timer frequency of your system may
> > +	  change in different boot stage.
> > +
> >  endif
> >  
> >  endmenu
> > diff --git a/arch/mips/cpu/time.c b/arch/mips/cpu/time.c
> > index af324f77ce..61d1cd9ec0 100644
> > --- a/arch/mips/cpu/time.c
> > +++ b/arch/mips/cpu/time.c
> > @@ -12,7 +12,9 @@ unsigned long notrace timer_read_counter(void)
> >  	return read_c0_count();
> >  }
> >  
> > +#ifndef CONFIG_MIPS_OVERRIDE_GET_TBCLK
> >  ulong notrace get_tbclk(void)
> >  {
> >  	return CONFIG_SYS_MIPS_TIMER_FREQ;
> >  }
> > +#endif
> > 
> 
> you can drop this patch. I already applied [1] because there was another
> request to make this function weak.
> 
> [1] https://patchwork.ozlabs.org/patch/1215073/
> 

OK

      reply	other threads:[~2020-01-09  8:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08  3:01 [PATCH 04/16] mips: add an option to support customized get_tbclk() Weijie Gao
2020-01-08 14:32 ` Daniel Schwierzeck
2020-01-09  8:30   ` Weijie Gao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1578558622.5535.13.camel@mcddlt001 \
    --to=weijie.gao@mediatek.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox