From mboxrd@z Thu Jan  1 00:00:00 1970
From: Weijie Gao <weijie.gao@mediatek.com>
Date: Wed, 15 Apr 2020 15:19:44 +0800
Subject: [PATCH 1/3] mips: mt76x8: ddr_cal: Rename dqs_test_valid() to
 dqs_test_error()
In-Reply-To: <20200306141405.24539-1-sr@denx.de>
References: <20200306141405.24539-1-sr@denx.de>
Message-ID: <1586935184.26858.143.camel@mcddlt001>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, 2020-03-06 at 15:14 +0100, Stefan Roese wrote:
> This function returns "-1" (true) upon error. So the function name does
> not match its implementation which is confusing. This patch renames the
> function to dqs_test_error() which makes the code easier to read.
> 
> Also change the return type to bool and return "true" or "false".
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Weijie Gao <weijie.gao@mediatek.com>
> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> ---
>  arch/mips/mach-mtmips/ddr_cal.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 

Reviewed-by: Weijie Gao <weijie.gao@mediatek.com>