public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 3/3] mkimage: fit: Free buf directly in fit_extract_data()
Date: Sat, 18 Apr 2020 01:59:11 -0700	[thread overview]
Message-ID: <1587200351-12590-3-git-send-email-bmeng.cn@gmail.com> (raw)
In-Reply-To: <1587200351-12590-1-git-send-email-bmeng.cn@gmail.com>

From: Bin Meng <bin.meng@windriver.com>

If given ptr to free() is NULL, no operation is performed.
Hence we can just free buf directly in fit_extract_data().

Signed-off-by: Bin Meng <bin.meng@windriver.com>
---

 tools/fit_image.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/fit_image.c b/tools/fit_image.c
index 05c1f00..965061d 100644
--- a/tools/fit_image.c
+++ b/tools/fit_image.c
@@ -527,8 +527,7 @@ static int fit_extract_data(struct image_tool_params *params, const char *fname)
 err_munmap:
 	munmap(fdt, sbuf.st_size);
 err:
-	if (buf)
-		free(buf);
+	free(buf);
 	close(fd);
 	return ret;
 }
-- 
2.7.4

  parent reply	other threads:[~2020-04-18  8:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-18  8:59 [PATCH 1/3] tools: Remove the out-of-date MinGW support codes Bin Meng
2020-04-18  8:59 ` [PATCH 2/3] mkimage: fit: Unmmap the memory before closing fd in fit_import_data() Bin Meng
2020-04-24 17:12   ` Tom Rini
2020-04-18  8:59 ` Bin Meng [this message]
2020-04-24 17:13   ` [PATCH 3/3] mkimage: fit: Free buf directly in fit_extract_data() Tom Rini
2020-04-24 17:12 ` [PATCH 1/3] tools: Remove the out-of-date MinGW support codes Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1587200351-12590-3-git-send-email-bmeng.cn@gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox