From: rahasij <rahasij@linux.microsoft.com>
To: u-boot@lists.denx.de
Subject: [PATCH v4] net: tftp: Add client support for RFC 7440
Date: Thu, 21 May 2020 17:29:25 -0700 (MST) [thread overview]
Message-ID: <1590107365262-0.post@n7.nabble.com> (raw)
In-Reply-To: <20200519192557.18075-1-rfried.dev@gmail.com>
Ramon Fried-4 wrote
> + if (strcmp((char *)pkt + i, "windowsize") == 0) {
> + tftp_windowsize =
> + simple_strtoul((char *)pkt + i + 11,
> + NULL, 10);
> + debug("windowsize = %s, %d\n",
> + (char *)pkt + i + 11, tftp_windowsize);
> + }
> +
> }
> --
> 2.26.2
As per RFC2347, the option string is case insensitive. I fixed this for
other options in following patch
https://lists.denx.de/pipermail/u-boot/2020-May/412472.html
Please use strcasecmp() instead of strcmp().
As per RFC7440, the value received from server should be less than or equal
to the value proposed by client . This check should be added here, and error
packet must be generated in case of failure.
Above patch implements ERR pkt generation and should be applied first.
--
Sent from: http://u-boot.10912.n7.nabble.com/
next prev parent reply other threads:[~2020-05-22 0:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 19:25 [PATCH v4] net: tftp: Add client support for RFC 7440 Ramon Fried
2020-05-22 0:29 ` rahasij [this message]
2020-05-22 19:19 ` Ramon Fried
2020-05-23 17:39 ` Matthias Brugger
2020-05-23 17:59 ` Ramon Fried
2020-06-03 2:54 ` Ravik Hasija
2020-06-04 16:17 ` Ramon Fried
2020-06-04 17:51 ` Ravik Hasija
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1590107365262-0.post@n7.nabble.com \
--to=rahasij@linux.microsoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox